Bugzilla – Attachment 39174 Details for
Bug 14184
Noisy warns in C4/CourseReserves.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm
Bug-14184-Undefined-term-causes-noisy-warns-in-C4C.patch (text/plain), 1.37 KB, created by
Indranil Das Gupta
on 2015-05-14 01:00:37 UTC
(
hide
)
Description:
Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm
Filename:
MIME Type:
Creator:
Indranil Das Gupta
Created:
2015-05-14 01:00:37 UTC
Size:
1.37 KB
patch
obsolete
>From 5df86306350d5f22f061f635d7be79c624aab91c Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Tue, 12 May 2015 02:08:17 +0000 >Subject: [PATCH] Bug 14184: Undefined $term causes noisy warns in > C4/CourseReserves.pm > >This patch sets $term to be an empty string. > >Test plan >========= > >1/ enable 'UseCourseReserves' syspref in Circulation preferences >2/ in a terminal, run a `tail -f ` on your instance's opac-error.log >3/ go to the opac, click on 'Course reserve' tab to go to > opac-course-reserves.pl >4/ notice the warning - "opac-course-reserves.pl: Use of uninitialized > value $term" appear in the `tail`ed opac-error.log >5/ apply the patch >6/ reload the page (opac-course-reserves.pl) >7/ page works but the warning in step #4 is no longer logged >8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error > >Remarks: Testing result match expected test plan output. The QA tests > pass with "OK" for the commit. > >Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> >--- > C4/CourseReserves.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/CourseReserves.pm b/C4/CourseReserves.pm >index 4a7bb22..7e160d0 100644 >--- a/C4/CourseReserves.pm >+++ b/C4/CourseReserves.pm >@@ -1052,6 +1052,7 @@ sub SearchCourses { > GROUP BY c.course_id > "; > >+ $term //= ''; > $term = "%$term%"; > @params = ($term) x 10; > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14184
:
39055
|
39174
|
39405