From 2c23f2e6d468b07a53efae5d34900e49fc37c0f1 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 14 May 2015 06:20:00 -0400 Subject: [PATCH] Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases For some reason the regular expression used to split the multiple ISBN fields can fail which keeps Business::ISBN from being able to parse out and return a valid isbn. Using split() instead of the regex fixes the issue. Test Plan: 1) Apply the unit test patch first 2) prove t/Koha.t 3) Note the failures 4) Apply the second patch 5) prove t/Koha.t 6) Note all tests pass --- C4/Koha.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/Koha.pm b/C4/Koha.pm index cb0ed5a..4f54a3b 100644 --- a/C4/Koha.pm +++ b/C4/Koha.pm @@ -1487,7 +1487,7 @@ sub GetNormalizedISBN { if ($isbn) { # Koha attempts to store multiple ISBNs in biblioitems.isbn, separated by " | " # anything after " | " should be removed, along with the delimiter - $isbn =~ s/(.*)( \| )(.*)/$1/; + ($isbn) = split(/\|/, $isbn ); return _isbn_cleanup($isbn); } return unless $record; -- 1.7.2.5