From 64a4f4ab6334b5b42c296cac17660f1d55f1322e Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 14 May 2015 15:09:40 +0200 Subject: [PATCH] Bug 13437: Replace javascript function parameter in builder Content-Type: text/plain; charset=utf-8 The builder contains js functions with a parameter like subfield_managed or i or something similar. This parameter contains the html id of the field corresponding with the plugin. With the functionality of Koha::FrameworkPlugin in place, we can eliminate one js function call and get the same id via the event passed in. Note that this actually makes the function a 'real' event handler. Also note that in many cases this parameter was not used but the id was borrowed from a perl variable like $params->{id}. If the field is not cloned, this is not a problem. But some fields can be cloned and should not use the static perl value but should get it from the event. Test plan: Look for js errors when loading the marc editor. Since the Focus or Click event code has been touched for most marc21 plugins, move your cursor into the field or click on the tag editor button. Verify that the focus event updates the correct field or the click event correctly launches the plugin AND the value comes back into the right field. Bonus: Attach a plugin with popup (like leader) to 040$d. Clone this field. Verify that the two launch buttons operate on the correct value. (This resolves a current bug.) Signed-off-by: Marcel de Rooy Checked all 15 plugins. Plugin marc21_linking_section seems to work, but I could not get it to pass back something useful into my field. (Same without this patch.) Tested the clone button with leader on 040d. --- cataloguing/value_builder/marc21_field_003.pl | 4 ++-- cataloguing/value_builder/marc21_field_005.pl | 4 ++-- cataloguing/value_builder/marc21_field_006.pl | 6 +++--- cataloguing/value_builder/marc21_field_007.pl | 6 +++--- cataloguing/value_builder/marc21_field_008.pl | 12 ++++++------ cataloguing/value_builder/marc21_field_008_authorities.pl | 12 ++++++------ cataloguing/value_builder/marc21_field_040c.pl | 4 ++-- cataloguing/value_builder/marc21_field_040d.pl | 4 ++-- cataloguing/value_builder/marc21_field_245h.pl | 6 +++--- cataloguing/value_builder/marc21_leader.pl | 12 ++++++------ cataloguing/value_builder/marc21_leader_authorities.pl | 12 ++++++------ cataloguing/value_builder/marc21_leader_book.pl | 6 +++--- cataloguing/value_builder/marc21_leader_computerfile.pl | 6 +++--- cataloguing/value_builder/marc21_leader_video.pl | 6 +++--- cataloguing/value_builder/marc21_linking_section.pl | 6 +++--- 15 files changed, 53 insertions(+), 53 deletions(-) diff --git a/cataloguing/value_builder/marc21_field_003.pl b/cataloguing/value_builder/marc21_field_003.pl index 9844863..189a00a 100755 --- a/cataloguing/value_builder/marc21_field_003.pl +++ b/cataloguing/value_builder/marc21_field_003.pl @@ -32,8 +32,8 @@ my $builder = sub { -- 1.7.10.4