From 4252183374ed022414ed3ce7c65a73ebcd9505e9 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Wed, 13 May 2015 13:47:38 +0200 Subject: [PATCH] Bug 13437: Trivial edits on marc21 plugins before conversion Content-Type: text/plain; charset=utf-8 marc21_field_003.pl: copy-pasta comment about date removed marc21_field_005.pl: commented use removed marc21_field_006.pl: old/irrelevant pod lines marc21_field_007.pl: old/irrelevant pod lines marc21_field_008.pl: old/irrelevant pod lines, move sub par line twice marc21_field_008_authorities.pl: whitespace, old/irrelevant pod lines marc21_field_040c.pl: two commented lines removed marc21_field_040d.pl: whitespace, commented lines, old/irrelevant pod marc21_field_245h.pl: whitespace marc21_linking_section.pl: relocated some comment lines, and replaced a new CGI object by the one passed in via the plugin launcher (agreed, this may not be so trivial as the other changes) Test plan: These (trivial) changes are hard to test. Pick a few plugins and verify that behavior is not changed in the marc editor. For the brave: Try marc21_linking_section.pl. --- cataloguing/value_builder/marc21_field_003.pl | 1 - cataloguing/value_builder/marc21_field_005.pl | 1 - cataloguing/value_builder/marc21_field_006.pl | 6 ------ cataloguing/value_builder/marc21_field_007.pl | 6 ------ cataloguing/value_builder/marc21_field_008.pl | 11 +++-------- .../value_builder/marc21_field_008_authorities.pl | 7 +------ cataloguing/value_builder/marc21_field_040c.pl | 2 -- cataloguing/value_builder/marc21_field_040d.pl | 11 +---------- cataloguing/value_builder/marc21_field_245h.pl | 3 +-- cataloguing/value_builder/marc21_linking_section.pl | 15 +++++---------- 10 files changed, 11 insertions(+), 52 deletions(-) diff --git a/cataloguing/value_builder/marc21_field_003.pl b/cataloguing/value_builder/marc21_field_003.pl index ef0eca5..4a3b516 100755 --- a/cataloguing/value_builder/marc21_field_003.pl +++ b/cataloguing/value_builder/marc21_field_003.pl @@ -26,7 +26,6 @@ sub plugin_javascript { my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; my $function_name= $field_number; - # find today's date my $org = C4::Context->preference('MARCOrgCode'); my $res = " "; -return ($function_name,$res); + return ($function_name,$res); } diff --git a/cataloguing/value_builder/marc21_field_245h.pl b/cataloguing/value_builder/marc21_field_245h.pl index 8d4b356..1912c4c 100755 --- a/cataloguing/value_builder/marc21_field_245h.pl +++ b/cataloguing/value_builder/marc21_field_245h.pl @@ -1,6 +1,5 @@ #!/usr/bin/perl - # Copyright 2009 Kyle Hall # # This file is part of Koha. @@ -44,5 +43,5 @@ function Blur$function_name(index) { //]]> "; -return ($function_name,$res); + return ($function_name,$res); } diff --git a/cataloguing/value_builder/marc21_linking_section.pl b/cataloguing/value_builder/marc21_linking_section.pl index 723840f..f53ed2a 100644 --- a/cataloguing/value_builder/marc21_linking_section.pl +++ b/cataloguing/value_builder/marc21_linking_section.pl @@ -49,19 +49,14 @@ sub plugin_javascript { return ( $function_name, $res ); } -# sub plugin -# -# input arg : -# -- op could be equals to -# * fillinput : -# * do_search : -# - sub plugin { - my ($input) = @_; + my ($query) = @_; my $dbh = C4::Context->dbh; - my $query = new CGI; my $op = $query->param('op'); + # -- op could be equal to + # * fillinput + # * do_search + my $type = $query->param('type'); my $startfrom = $query->param('startfrom'); $startfrom = 0 if ( !defined $startfrom ); -- 1.7.10.4