From 408c597ce235b536d47d126c3f2d8357beb88c1a Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Fri, 1 May 2015 17:09:58 -0400 Subject: [PATCH] Bug 14114: Silence warns and cleanup t/Debug.t TEST PLAN --------- 1) $ prove t/Debug.t -- What's with this BEFORE and AFTER stuff?! 2) apply patch 3) $ prove t/Debug.t -- cleaner, and you only get fuller output with -v. 4) koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel Cleaner, no koha-qa errors Signed-off-by: Jonathan Druart --- t/Debug.t | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/t/Debug.t b/t/Debug.t index 54ef5c6..3202164 100755 --- a/t/Debug.t +++ b/t/Debug.t @@ -1,25 +1,19 @@ #!/usr/bin/perl -use strict; -use warnings; - -use Test::More tests => 5; +use Modern::Perl; +use Test::More tests => 7; use vars qw($debug $cgi_debug); BEGIN { -$ENV{'KOHA_CGI_DEBUG'}='2'; -$ENV{'KOHA_DEBUG'}='5'; - diag "BEFORE use: \$debug is " . (defined $debug ? $debug : 'not defined'); - diag "BEFORE use: \$cgi_debug is " . (defined $cgi_debug ? $cgi_debug : 'not defined'); - use_ok('C4::Debug'); + $ENV{'KOHA_CGI_DEBUG'}='2'; + $ENV{'KOHA_DEBUG'}='5'; + is($debug, undef," \$debug is undefined as expected."); + is($cgi_debug,undef,"\$cgi_debug is undefined as expected."); + use_ok('C4::Debug'); } -diag " AFTER use: \$debug is " . (defined $debug ? $debug : 'not defined'); -diag " AFTER use: \$cgi_debug is " . (defined $cgi_debug ? $cgi_debug : 'not defined'); ok(defined $debug, " \$debug defined and imported."); ok(defined $cgi_debug, "\$cgi_debug defined and imported."); is($cgi_debug,2,"cgi_debug gets the ENV{'KOHA_CGI_DEBUG'}"); is($debug,5,"debug gets the ENV{'KOHA_DEBUG'}"); - -diag "Done."; -- 2.1.0