Bugzilla – Attachment 39386 Details for
Bug 14118
Silence warnings t/DataTables/Members.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14118: Silence warnings t/DataTables/Members.t
Bug-14118-Silence-warnings-tDataTablesMemberst.patch (text/plain), 1.64 KB, created by
Jonathan Druart
on 2015-05-22 09:37:20 UTC
(
hide
)
Description:
Bug 14118: Silence warnings t/DataTables/Members.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-05-22 09:37:20 UTC
Size:
1.64 KB
patch
obsolete
>From 8f53d10e5117774fe97f4060f27ec9671fd8a730 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 1 May 2015 22:14:21 -0400 >Subject: [PATCH] Bug 14118: Silence warnings t/DataTables/Members.t > >After cleaning 'prove t' up. 'prove -r t' was attempted next. >A couple uninitialized variable warning were triggered. > >TEST PLAN >---------- >1) prove t/DataTables/Members.t > -- warnings. >2) apply patch >3) prove t/DataTables/Members.t > -- no warnings. >4) koha qa test tools. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Cleaned. No errors > >Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> >--- > C4/Utils/DataTables/Members.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm >index 767fc46..a63a582 100644 >--- a/C4/Utils/DataTables/Members.pm >+++ b/C4/Utils/DataTables/Members.pm >@@ -103,10 +103,10 @@ sub search { > > my $limit; > # If iDisplayLength == -1, we want to display all patrons >- if ( $dt_params->{iDisplayLength} > -1 ) { >+ if ( !$dt_params->{iDisplayLength} || $dt_params->{iDisplayLength} > -1 ) { > # In order to avoid sql injection >- $dt_params->{iDisplayStart} =~ s/\D//g; >- $dt_params->{iDisplayLength} =~ s/\D//g; >+ $dt_params->{iDisplayStart} =~ s/\D//g if defined($dt_params->{iDisplayStart}); >+ $dt_params->{iDisplayLength} =~ s/\D//g if defined($dt_params->{iDisplayLength}); > $dt_params->{iDisplayStart} //= 0; > $dt_params->{iDisplayLength} //= 20; > $limit = "LIMIT $dt_params->{iDisplayStart},$dt_params->{iDisplayLength}"; >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14118
:
38759
|
39229
| 39386 |
39387