@@ -, +, @@ --------- -- CGI security warning -- no noise. --- C4/Auth_with_cas.pm | 9 +++++---- t/db_dependent/Auth_with_cas.t | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) --- a/C4/Auth_with_cas.pm +++ a/C4/Auth_with_cas.pm @@ -208,13 +208,14 @@ sub _url_with_get_params { C4::Context->preference('staffClientBaseURL'); my $uri_params_part = ''; - foreach ( $query->url_param() ) { + foreach my $param ( $query->url_param() ) { # url_param() always returns parameters that were deleted by delete() # This additional check ensure that parameter was not deleted. - if ($query->param($_)) { + my $uriPiece = $query->param($param); + if ($uriPiece) { $uri_params_part .= '&' if $uri_params_part; - $uri_params_part .= $_ . '='; - $uri_params_part .= URI::Escape::uri_escape( $query->param($_) ); + $uri_params_part .= $param . '='; + $uri_params_part .= URI::Escape::uri_escape( $uriPiece ); } } $uri_base_part .= '?' if $uri_params_part; --- a/t/db_dependent/Auth_with_cas.t +++ a/t/db_dependent/Auth_with_cas.t @@ -38,6 +38,7 @@ my $dbh = C4::Context->dbh; $dbh->{ AutoCommit } = 0; $dbh->{ RaiseError } = 1; +C4::Context->disable_syspref_cache(); C4::Context->set_preference('OPACBaseURL','localhost'); C4::Context->set_preference('staffClientBaseURL','localhost:8080'); --