Bugzilla – Attachment 39641 Details for
Bug 14001
Inventory has bad $_ references
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14001: [DO NOT PUSH TO MASTER] Proof that the $_ is wrong.
Bug-14001-DO-NOT-PUSH-TO-MASTER-Proof-that-the--is.patch (text/plain), 5.45 KB, created by
Mark Tompsett
on 2015-05-28 16:21:25 UTC
(
hide
)
Description:
Bug 14001: [DO NOT PUSH TO MASTER] Proof that the $_ is wrong.
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2015-05-28 16:21:25 UTC
Size:
5.45 KB
patch
obsolete
>From 8ad3a7b94fadd3b804db2ec1a5a5eaeef621bb2a Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 28 May 2015 12:10:23 -0400 >Subject: [PATCH] Bug 14001: [DO NOT PUSH TO MASTER] Proof that the $_ is > wrong. > >TEST PLAN >--------- > 1) create new branch based on master > 2) apply this patch > 3) make sure you have the barcode of something in your inventory. > or add it accordingly. > 4) Create a dummy barcode file with that barcode. > 5) Home -> Tools -> Inventory/stocktaking > 6) Browse for that file > 7) Click the 'Compare barcodes list to results:' checkbox. > 8) Click the 'Submit' button. > 9) Check the koha error log. > -- Errors being looked for are like: >[Thu May 28 12:14:53.454702 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: [Thu May 28 12:14:53 2015] inventory.pl: Use of uninitialized value in concatenation (.) or string at /home/mtompset/kohaclone/tools/inventory.pl line 278, <$fh> line 1., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.454737 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $_ VERSION: , referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.454757 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $item VERSION: 2015-05-28, referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.455013 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: [Thu May 28 12:14:53 2015] inventory.pl: Use of uninitialized value in concatenation (.) or string at /home/mtompset/kohaclone/tools/inventory.pl line 278, <$fh> line 1., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.455033 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $_ VERSION: , referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.455052 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $item VERSION: 2015-05-25, referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.455345 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: [Thu May 28 12:14:53 2015] inventory.pl: Use of uninitialized value in concatenation (.) or string at /home/mtompset/kohaclone/tools/inventory.pl line 278, <$fh> line 1., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.455366 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $_ VERSION: , referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.455384 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $item VERSION: 2015-05-25, referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.455539 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: [Thu May 28 12:14:53 2015] inventory.pl: Use of uninitialized value in concatenation (.) or string at /home/mtompset/kohaclone/tools/inventory.pl line 278, <$fh> line 1., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.455539 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $_ VERSION: , referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.455540 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $item VERSION: 2015-05-25, referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.458994 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: [Thu May 28 12:14:53 2015] inventory.pl: Use of uninitialized value in concatenation (.) or string at /home/mtompset/kohaclone/tools/inventory.pl line 325, <$fh> line 1., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.459018 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $_ VERSION (MOD): , referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl >[Thu May 28 12:14:53.459037 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $item VERSION (MOD): 2, referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl > >As this should not be pushed to master, and is merely provided as evidence that there is a problem. >Confirm that the two places correspond to the VERSION and VERSION (MOD) message locations. >--- > tools/inventory.pl | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/tools/inventory.pl b/tools/inventory.pl >index 015d0be..3869aa2 100755 >--- a/tools/inventory.pl >+++ b/tools/inventory.pl >@@ -275,6 +275,8 @@ if ( $compareinv2barcd ) { > foreach my $item ( @$inventorylist ) { > my $cdls = output_pref( { dt => dt_from_string( $_->{datelastseen} ), > dateformat => 'iso' } ); >+ print STDERR "\$_ VERSION: " . $_->{datelastseen} . "\n"; >+ print STDERR "\$item VERSION: " . $item->{datelastseen} . "\n"; > if ( $cdls lt $dls ) { > $item->{problem} = 'missingitem'; > # We have to push a copy of the item, not the reference >@@ -320,6 +322,8 @@ foreach my $item ( @scanned_items ) { > } > > # Modify date last seen for scanned items >+ print STDERR "\$_ VERSION (MOD): " . $_->{'itemnumber'} . "\n"; >+ print STDERR "\$item VERSION (MOD): " . $item->{'itemnumber'} . "\n"; > ModDateLastSeen($_->{'itemnumber'}); > $moddatecount++; > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14001
:
37910
|
37924
|
39641
|
39642
|
39643
|
40117
|
40118
|
40164