Bugzilla – Attachment 39743 Details for
Bug 14299
Today's checkouts not always sorting correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 14299 - Today's checkouts not always sorting correctly
Signed-off-Bug-14299---Todays-checkouts-not-always.patch (text/plain), 1.34 KB, created by
Marc Véron
on 2015-06-01 13:33:55 UTC
(
hide
)
Description:
[Signed-off] Bug 14299 - Today's checkouts not always sorting correctly
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-06-01 13:33:55 UTC
Size:
1.34 KB
patch
obsolete
>From 2f073714cd2e0bca6e27359a36a96c8c04eec5e6 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 29 May 2015 09:36:34 -0400 >Subject: [PATCH] [Signed-off] Bug 14299 - Today's checkouts not always > sorting correctly >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Sometimes the today's checkouts do not sort correctly. This is due to a >simple typo in the comparison line where the bad key 'timstamp' is >compared against the correct key 'timestamp'. > >Test Plan: >1) Check out a decent number of items in a row ( 5+ ) >2) Hopefully you will see they are sorted incorrectly >3) Apply this patch >4) Reload the page >5) Note they are now sorted correctly > >Followed test plan. Works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > svc/checkouts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/svc/checkouts b/svc/checkouts >index d2eb8ee..cc703ae 100755 >--- a/svc/checkouts >+++ b/svc/checkouts >@@ -210,7 +210,7 @@ while ( my $c = $sth->fetchrow_hashref() ) { > } > > >-@checkouts_today = sort { $a->{timstamp} cmp $b->{timestamp} } @checkouts_today; >+@checkouts_today = sort { $a->{timestamp} cmp $b->{timestamp} } @checkouts_today; > @checkouts_today = reverse(@checkouts_today) > unless ( C4::Context->preference('todaysIssuesDefaultSortOrder') eq 'desc' ); > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14299
:
39687
|
39688
|
39743
|
39810