Bugzilla – Attachment 39937 Details for
Bug 14344
uninitialized value warning C4/Utils/DataTables/Members.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14344: uninitialized value warning C4/Utils/DataTables/Members.pm
PASSED-QA-Bug-14344-uninitialized-value-warning-C4.patch (text/plain), 1.86 KB, created by
Katrin Fischer
on 2015-06-06 14:14:41 UTC
(
hide
)
Description:
[PASSED QA] Bug 14344: uninitialized value warning C4/Utils/DataTables/Members.pm
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-06-06 14:14:41 UTC
Size:
1.86 KB
patch
obsolete
>From 22ba82da7261f1ef52131c74f33c60e13880aa34 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Fri, 5 Jun 2015 12:01:28 -0300 >Subject: [PATCH] [PASSED QA] Bug 14344: uninitialized value warning > C4/Utils/DataTables/Members.pm > >The condition for the assignment depends on $searchtype to be defined >and equal to 'contains'. So this change doesn't change the semantics. > >- if $term !~ /^%/ >- and $searchtype eq "contain"; >+ if (defined $searchtype) && $searchtype eq "contain" >+ && $term !~ /^%/; > >To test: >- Home -> Circulation -> Checkout >- Search for a user that does not exist (I searched 'whywouldthisexist') on the intranet interface. >- Look at the intranet logs >=> FAIL: you get "Use of uninitialized value $searchtype in string eq at.,," >- Apply the patch >- Repeat the search >=> SUCCESS: No warning >- Sign off :-D > >NOTE: Other pages are more forgiving. Tweaked test plan. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Utils/DataTables/Members.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm >index a63a582..6b365c5 100644 >--- a/C4/Utils/DataTables/Members.pm >+++ b/C4/Utils/DataTables/Members.pm >@@ -76,8 +76,8 @@ sub search { > $term .= '%' # end with anything > if $term !~ /%$/; > $term = "%$term" # begin with anythin unless start_with >- if $term !~ /^%/ >- and $searchtype eq "contain"; >+ if (defined $searchtype) && $searchtype eq "contain" >+ && $term !~ /^%/; > my @where_strs_or; > for my $searchfield ( split /,/, $searchfields->{$searchfieldstype} ) { > push @where_strs_or, "borrowers." . $dbh->quote_identifier($searchfield) . " LIKE ?"; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14344
:
39911
|
39914
| 39937