Bugzilla – Attachment 40066 Details for
Bug 14360
XSS Injection point
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14360: Unescaped variable causes alert
PASSED-QA-Bug-14360-Unescaped-variable-causes-aler.patch (text/plain), 3.66 KB, created by
Kyle M Hall
on 2015-06-10 13:16:14 UTC
(
hide
)
Description:
[PASSED QA] Bug 14360: Unescaped variable causes alert
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2015-06-10 13:16:14 UTC
Size:
3.66 KB
patch
obsolete
>From b48298663b43eed0c4f54b9dacffe4fc0449572a Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Mon, 8 Jun 2015 02:30:23 +0000 >Subject: [PATCH] [PASSED QA] Bug 14360: Unescaped variable causes alert > >Adding |html to [% resultsperpage %] to escape the variable and get rid of the alert. > >To test: > >1) Go to URL such as ... /cgi-bin/koha/opac-authorities-home.pl?op=do_search&resultsperpage=1%22%3E%3Cscript%3Ealert%28document.cookie%29%3C/script%3E >2) Notice pop-up box with alert >3) Apply patch, refresh page >4) Notice alert is gone > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../en/modules/opac-authoritiessearchresultlist.tt | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt >index 00d657e..d4a264b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt >@@ -6,7 +6,7 @@ > <ul> > [% IF ( displayprev ) %] > <li> >- <a href="opac-authorities-home.pl?startfrom=[% startfromprev %]&[% FOREACH searchdat IN searchdata %][% searchdat.term %]=[% searchdat.val |url %]&[% END %]resultsperpage=[% resultsperpage %]&type=opac&op=do_search&authtypecode=[% authtypecode %]&orderby=[% orderby|html %]"> >+ <a href="opac-authorities-home.pl?startfrom=[% startfromprev %]&[% FOREACH searchdat IN searchdata %][% searchdat.term %]=[% searchdat.val |url %]&[% END %]resultsperpage=[% resultsperpage |html %]&type=opac&op=do_search&authtypecode=[% authtypecode %]&orderby=[% orderby|html %]"> > « > </a> > </li> >@@ -15,12 +15,12 @@ > [% IF ( number.highlight ) %] > <li class="active"><a href="#">[% number.number %]</a></li> > [% ELSE %] >- <li><a href="opac-authorities-home.pl?startfrom=[% number.startfrom %]&[% FOREACH searchdat IN number.searchdata %][% searchdat.term %]=[% searchdat.val |url %]&[% END %]resultsperpage=[% resultsperpage %]&type=opac&op=do_search&authtypecode=[% authtypecode %]&orderby=[% orderby|html %]">[% number.number %]</a></li> >+ <li><a href="opac-authorities-home.pl?startfrom=[% number.startfrom %]&[% FOREACH searchdat IN number.searchdata %][% searchdat.term %]=[% searchdat.val |url %]&[% END %]resultsperpage=[% resultsperpage |html %]&type=opac&op=do_search&authtypecode=[% authtypecode %]&orderby=[% orderby|html %]">[% number.number %]</a></li> > [% END %] > [% END %] > [% IF ( displaynext ) %] > <li> >- <a href="opac-authorities-home.pl?startfrom=[% startfromnext %]&[% FOREACH searchdat IN searchdata %][% searchdat.term %]=[% searchdat.val |url %]&[% END %]&resultsperpage=[% resultsperpage %]&type=opac&op=do_search&authtypecode=[% authtypecode %]&orderby=[% orderby|html %]">»</a> >+ <a href="opac-authorities-home.pl?startfrom=[% startfromnext %]&[% FOREACH searchdat IN searchdata %][% searchdat.term %]=[% searchdat.val |url %]&[% END %]&resultsperpage=[% resultsperpage |html %]&type=opac&op=do_search&authtypecode=[% authtypecode %]&orderby=[% orderby|html %]">»</a> > </li> > [% END %] > </ul> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14360
:
39981
|
40009
|
40045
|
40046
| 40066 |
40067