View | Details | Raw Unified | Return to bug 14383
Collapse All | Expand All

(-)a/C4/Acquisition.pm (-4 / +4 lines)
Lines 1692-1698 sub SearchOrders { Link Here
1692
            LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber
1692
            LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber
1693
    };
1693
    };
1694
1694
1695
    # If we search on ordernumber, we retrieve the transfered order if a transfer has been done.
1695
    # If we search on ordernumber, we retrieve the transferred order if a transfer has been done.
1696
    $query .= q{
1696
    $query .= q{
1697
            LEFT JOIN aqorders_transfers ON aqorders_transfers.ordernumber_to = aqorders.ordernumber
1697
            LEFT JOIN aqorders_transfers ON aqorders_transfers.ordernumber_to = aqorders.ordernumber
1698
    } if $ordernumber;
1698
    } if $ordernumber;
Lines 1838-1848 sub DelOrder { Link Here
1838
    my $newordernumber = TransferOrder($ordernumber, $basketno);
1838
    my $newordernumber = TransferOrder($ordernumber, $basketno);
1839
1839
1840
Transfer an order line to a basket.
1840
Transfer an order line to a basket.
1841
Mark $ordernumber as cancelled with an internal note 'Cancelled and transfered
1841
Mark $ordernumber as cancelled with an internal note 'Cancelled and transferred
1842
to BOOKSELLER on DATE' and create new order with internal note
1842
to BOOKSELLER on DATE' and create new order with internal note
1843
'Transfered from BOOKSELLER on DATE'.
1843
'Transferred from BOOKSELLER on DATE'.
1844
Move all attached items to the new order.
1844
Move all attached items to the new order.
1845
Received orders cannot be transfered.
1845
Received orders cannot be transferred.
1846
Return the ordernumber of created order.
1846
Return the ordernumber of created order.
1847
1847
1848
=cut
1848
=cut
(-)a/C4/Auth.pm (-4 / +4 lines)
Lines 320-326 sub get_template_and_user { Link Here
320
    else {    # if this is an anonymous session, setup to display public lists...
320
    else {    # if this is an anonymous session, setup to display public lists...
321
321
322
        # If shibboleth is enabled, and we're in an anonymous session, we should allow
322
        # If shibboleth is enabled, and we're in an anonymous session, we should allow
323
        # the user to attemp login via shibboleth.
323
        # the user to attempt login via shibboleth.
324
        if ($shib) {
324
        if ($shib) {
325
            $template->param( shibbolethAuthentication => $shib,
325
            $template->param( shibbolethAuthentication => $shib,
326
                shibbolethLoginUrl => login_shib_url( $in->{'query'} ),
326
                shibbolethLoginUrl => login_shib_url( $in->{'query'} ),
Lines 637-643 sub _version_check { Link Here
637
    my $query = shift;
637
    my $query = shift;
638
    my $version;
638
    my $version;
639
639
640
    # If Version syspref is unavailable, it means Koha is beeing installed,
640
    # If version syspref is unavailable, it means Koha is being installed,
641
    # and so we must redirect to OPAC maintenance page or to the WebInstaller
641
    # and so we must redirect to OPAC maintenance page or to the WebInstaller
642
    # also, if OpacMaintenance is ON, OPAC should redirect to maintenance
642
    # also, if OpacMaintenance is ON, OPAC should redirect to maintenance
643
    if ( C4::Context->preference('OpacMaintenance') && $type eq 'opac' ) {
643
    if ( C4::Context->preference('OpacMaintenance') && $type eq 'opac' ) {
Lines 746-752 sub checkauth { Link Here
746
    }
746
    }
747
    elsif ($persona) {
747
    elsif ($persona) {
748
748
749
        # we dont want to set a session because we are being called by a persona callback
749
        # we don't want to set a session because we are being called by a persona callback
750
    }
750
    }
751
    elsif ( $sessionID = $query->cookie("CGISESSID") )
751
    elsif ( $sessionID = $query->cookie("CGISESSID") )
752
    {    # assignment, not comparison
752
    {    # assignment, not comparison
Lines 902-908 sub checkauth { Link Here
902
                $info{'invalidShibLogin'} = 1 unless ($return);
902
                $info{'invalidShibLogin'} = 1 unless ($return);
903
            }
903
            }
904
904
905
            # If shib login and match were successfull, skip further login methods
905
            # If shib login and match were successful, skip further login methods
906
            unless ($shibSuccess) {
906
            unless ($shibSuccess) {
907
                if ( $cas && $query->param('ticket') ) {
907
                if ( $cas && $query->param('ticket') ) {
908
                    my $retuserid;
908
                    my $retuserid;
(-)a/C4/AuthoritiesMarc.pm (-1 / +1 lines)
Lines 888-894 sub FindDuplicateAuthority { Link Here
888
888
889
Returns a hashref with a summary of the specified record.
889
Returns a hashref with a summary of the specified record.
890
890
891
Comment : authtypecode can be infered from both record and authid.
891
Comment : authtypecode can be inferred from both record and authid.
892
Moreover, authid can also be inferred from $record.
892
Moreover, authid can also be inferred from $record.
893
Would it be interesting to delete those things.
893
Would it be interesting to delete those things.
894
894
(-)a/C4/Barcodes.pm (-1 / +1 lines)
Lines 133-139 sub next_value { Link Here
133
	}
133
	}
134
	my $x = length($incr);		# number of digits
134
	my $x = length($incr);		# number of digits
135
	$incr =~ /^9+$/ and $x++;	# if they're all 9's, we need an extra.
135
	$incr =~ /^9+$/ and $x++;	# if they're all 9's, we need an extra.
136
		# Note, this enlargement might be undesireable for some barcode formats.
136
		# Note, this enlargement might be undesirable for some barcode formats.
137
		# Those should override next_value() to work accordingly.
137
		# Those should override next_value() to work accordingly.
138
	$incr++;
138
	$incr++;
139
139
(-)a/C4/Barcodes/hbyymmincr.pm (-1 / +1 lines)
Lines 129-135 __END__ Link Here
129
129
130
This format is deprecated and SHOULD NOT BE USED.
130
This format is deprecated and SHOULD NOT BE USED.
131
131
132
It is fairly clear the originator of the format did not intend to accomodate 
132
It is fairly clear the originator of the format did not intend to accommodate
133
multiple branch libraries, given that the format caps the available namespace to
133
multiple branch libraries, given that the format caps the available namespace to
134
10,000 barcodes per year TOTAL.  
134
10,000 barcodes per year TOTAL.  
135
135
(-)a/C4/Biblio.pm (-3 / +3 lines)
Lines 126-133 BEGIN { Link Here
126
126
127
    # Internal functions
127
    # Internal functions
128
    # those functions are exported but should not be used
128
    # those functions are exported but should not be used
129
    # they are usefull is few circumstances, so are exported.
129
    # they are useful in a few circumstances, so they are exported,
130
    # but don't use them unless you're a core developer ;-)
130
    # but don't use them unless you are a core developer ;-)
131
    push @EXPORT, qw(
131
    push @EXPORT, qw(
132
      &ModBiblioMarc
132
      &ModBiblioMarc
133
    );
133
    );
Lines 1519-1525 sub MungeMarcPrice { Link Here
1519
            (                          # start of capturing parenthesis
1519
            (                          # start of capturing parenthesis
1520
            (?:
1520
            (?:
1521
            (?:[\p{Sc}\p{L}\/.]){1,4}  # any character from Currency signs or Letter Unicode categories or slash or dot                                              within 1 to 4 occurrences : call this whole block 'symbol block'
1521
            (?:[\p{Sc}\p{L}\/.]){1,4}  # any character from Currency signs or Letter Unicode categories or slash or dot                                              within 1 to 4 occurrences : call this whole block 'symbol block'
1522
            |(?:\d+[\p{P}\s]?){1,4}    # or else at least one digit followed or not by a punctuation sign or whitespace,                                             all theese within 1 to 4 occurrences : call this whole block 'digits block'
1522
            |(?:\d+[\p{P}\s]?){1,4}    # or else at least one digit followed or not by a punctuation sign or whitespace,                                             all these within 1 to 4 occurrences : call this whole block 'digits block'
1523
            )
1523
            )
1524
            \s?\p{Sc}?\s?              # followed or not by a whitespace. \p{Sc}?\s? are for cases like '25$ USD'
1524
            \s?\p{Sc}?\s?              # followed or not by a whitespace. \p{Sc}?\s? are for cases like '25$ USD'
1525
            (?:
1525
            (?:
(-)a/C4/Branch.pm (-2 / +2 lines)
Lines 186-194 sub GetBranchName { Link Here
186
186
187
$error = &ModBranch($newvalue);
187
$error = &ModBranch($newvalue);
188
188
189
This function modify an existing branch
189
This function modifies an existing branch
190
190
191
C<$newvalue> is a ref to an array wich is containt all the column from branches table.
191
C<$newvalue> is a ref to an array which contains all the columns from branches table.
192
192
193
=cut
193
=cut
194
194
(-)a/C4/Calendar.pm (-1 / +1 lines)
Lines 165-171 sub get_exception_holidays { Link Here
165
    $single_holidays = $calendar->get_single_holidays();
165
    $single_holidays = $calendar->get_single_holidays();
166
166
167
Returns a hash reference to single holidays. This kind of holidays are those which
167
Returns a hash reference to single holidays. This kind of holidays are those which
168
happend just one time.
168
happened just one time.
169
169
170
=cut
170
=cut
171
171
(-)a/C4/Circulation.pm (-5 / +5 lines)
Lines 837-843 sub CanBookBeIssued { Link Here
837
    }
837
    }
838
838
839
#
839
#
840
    # JB34 CHECKS IF BORROWERS DONT HAVE ISSUE TOO MANY BOOKS
840
    # JB34 CHECKS IF BORROWERS DON'T HAVE ISSUE TOO MANY BOOKS
841
    #
841
    #
842
	my ($current_loan_count, $max_loans_allowed) = TooMany( $borrower, $item->{biblionumber}, $item );
842
	my ($current_loan_count, $max_loans_allowed) = TooMany( $borrower, $item->{biblionumber}, $item );
843
    # if TooMany max_loans_allowed returns 0 the user doesn't have permission to check out this book
843
    # if TooMany max_loans_allowed returns 0 the user doesn't have permission to check out this book
Lines 1293-1299 sub AddIssue { Link Here
1293
            UpdateTotalIssues($item->{'biblionumber'}, 1);
1293
            UpdateTotalIssues($item->{'biblionumber'}, 1);
1294
        }
1294
        }
1295
1295
1296
        ## If item was lost, it has now been found, reverse any list item charges if neccessary.
1296
        ## If item was lost, it has now been found, reverse any list item charges if necessary.
1297
        if ( $item->{'itemlost'} ) {
1297
        if ( $item->{'itemlost'} ) {
1298
            if ( C4::Context->preference('RefundLostItemFeeOnReturn' ) ) {
1298
            if ( C4::Context->preference('RefundLostItemFeeOnReturn' ) ) {
1299
                _FixAccountForLostAndReturned( $item->{'itemnumber'}, undef, $item->{'barcode'} );
1299
                _FixAccountForLostAndReturned( $item->{'itemnumber'}, undef, $item->{'barcode'} );
Lines 1767-1773 sub AddReturn { Link Here
1767
    my $issue  = GetItemIssue($itemnumber);
1767
    my $issue  = GetItemIssue($itemnumber);
1768
    if ($issue and $issue->{borrowernumber}) {
1768
    if ($issue and $issue->{borrowernumber}) {
1769
        $borrower = C4::Members::GetMemberDetails($issue->{borrowernumber})
1769
        $borrower = C4::Members::GetMemberDetails($issue->{borrowernumber})
1770
            or die "Data inconsistency: barcode $barcode (itemnumber:$itemnumber) claims to be issued to non-existant borrowernumber '$issue->{borrowernumber}'\n"
1770
            or die "Data inconsistency: barcode $barcode (itemnumber:$itemnumber) claims to be issued to non-existent borrowernumber '$issue->{borrowernumber}'\n"
1771
                . Dumper($issue) . "\n";
1771
                . Dumper($issue) . "\n";
1772
    } else {
1772
    } else {
1773
        $messages->{'NotIssued'} = $barcode;
1773
        $messages->{'NotIssued'} = $barcode;
Lines 3419-3425 sub CalcDateDue { Link Here
3419
        }
3419
        }
3420
    }
3420
    }
3421
3421
3422
    # if Hard Due Dates are used, retreive them and apply as necessary
3422
    # if Hard Due Dates are used, retrieve them and apply as necessary
3423
    my ( $hardduedate, $hardduedatecompare ) =
3423
    my ( $hardduedate, $hardduedatecompare ) =
3424
      GetHardDueDate( $borrower->{'categorycode'}, $itemtype, $branch );
3424
      GetHardDueDate( $borrower->{'categorycode'}, $itemtype, $branch );
3425
    if ($hardduedate) {    # hardduedates are currently dates
3425
    if ($hardduedate) {    # hardduedates are currently dates
Lines 3877-3883 sub GetAgeRestriction { Link Here
3877
    my @values = split ' ', uc($record_restrictions);
3877
    my @values = split ' ', uc($record_restrictions);
3878
    return unless @values;
3878
    return unless @values;
3879
3879
3880
    # Search first occurence of one of the markers
3880
    # Search first occurrence of one of the markers
3881
    my @markers = split /\|/, uc($markers);
3881
    my @markers = split /\|/, uc($markers);
3882
    return unless @markers;
3882
    return unless @markers;
3883
3883
(-)a/C4/ClassSortRoutine.pm (-1 / +1 lines)
Lines 48-54 use C4::ClassSortRoutine; Link Here
48
   &GetClassSortKey
48
   &GetClassSortKey
49
);
49
);
50
50
51
# intialization code
51
# initialization code
52
my %loaded_routines = ();
52
my %loaded_routines = ();
53
my @sort_routines = GetSortRoutineNames();
53
my @sort_routines = GetSortRoutineNames();
54
foreach my $sort_routine (@sort_routines) {
54
foreach my $sort_routine (@sort_routines) {
(-)a/C4/Context.pm (-2 / +2 lines)
Lines 288-294 sub import { Link Here
288
    # the first time the module is called
288
    # the first time the module is called
289
    # (a config file can be optionaly passed)
289
    # (a config file can be optionaly passed)
290
290
291
    # default context allready exists? 
291
    # default context already exists?
292
    return if $context;
292
    return if $context;
293
293
294
    # no ? so load it!
294
    # no ? so load it!
Lines 350-356 sub new { Link Here
350
    }
350
    }
351
    
351
    
352
    if ($ismemcached) {
352
    if ($ismemcached) {
353
        # retreive from memcached
353
        # retrieve from memcached
354
        $self = $memcached->get('kohaconf');
354
        $self = $memcached->get('kohaconf');
355
        if (not defined $self) {
355
        if (not defined $self) {
356
            # not in memcached yet
356
            # not in memcached yet
(-)a/C4/Creators/Batch.pm (-2 / +2 lines)
Lines 105-112 sub remove_item { Link Here
105
}
105
}
106
106
107
# FIXME: This method is effectively useless the way the current add_item method is written. Ideally, the items should be added to the object
107
# FIXME: This method is effectively useless the way the current add_item method is written. Ideally, the items should be added to the object
108
#       and then the save method called. This does not work well in practice due to the inability to pass objects accross cgi script calls.
108
#       and then the save method called. This does not work well in practice due to the inability to pass objects across cgi script calls.
109
#       I'm leaving it here because it should be here and for consistency's sake and once memcached support is fully implimented this should be as well. -cnighswonger
109
#       I'm leaving it here because it should be here and for consistency's sake and once memcached support is fully implemented this should be as well. -cnighswonger
110
#
110
#
111
#=head2 $batch->save()
111
#=head2 $batch->save()
112
#
112
#
(-)a/C4/Creators/Layout.pm (-3 / +3 lines)
Lines 129-136 sub delete { Link Here
129
        push @params, $opts{'layout_id'}, $opts{'creator'};
129
        push @params, $opts{'layout_id'}, $opts{'creator'};
130
    }
130
    }
131
    if (scalar(@params) < 2) {   # If there is no layout id or creator type then we cannot delete it
131
    if (scalar(@params) < 2) {   # If there is no layout id or creator type then we cannot delete it
132
        warn sprintf('%s : Cannot delete layout as the profile id is invalid or non-existant.', $call_type) if !$params[0];
132
        warn sprintf('%s : Cannot delete layout as the profile id is invalid or non-existent.', $call_type) if !$params[0];
133
        warn sprintf('%s : Cannot delete layout as the creator type is invalid or non-existant.', $call_type) if !$params[1];
133
        warn sprintf('%s : Cannot delete layout as the creator type is invalid or non-existent.', $call_type) if !$params[1];
134
        return -1;
134
        return -1;
135
    }
135
    }
136
    my $query = "DELETE FROM creator_layouts WHERE layout_id = ? AND creator = ?";
136
    my $query = "DELETE FROM creator_layouts WHERE layout_id = ? AND creator = ?";
Lines 267-273 This module provides methods for creating, retrieving, and otherwise manipulatin Link Here
267
            CODE39MOD10     = Code 3 of 9 with modulo 10 checksum
267
            CODE39MOD10     = Code 3 of 9 with modulo 10 checksum
268
268
269
=item .
269
=item .
270
            COOP2OF5        = A varient of 2 of 5 barcode based on NEC's "Process 8000" code
270
            COOP2OF5        = A variant of 2 of 5 barcode based on NEC's "Process 8000" code
271
271
272
=item .
272
=item .
273
            INDUSTRIAL2OF5  = The standard 2 of 5 barcode (a binary level bar code developed by Identicon Corp. and Computer Identics Corp. in 1970)
273
            INDUSTRIAL2OF5  = The standard 2 of 5 barcode (a binary level bar code developed by Identicon Corp. and Computer Identics Corp. in 1970)
(-)a/C4/Creators/PDF.pm (-1 / +1 lines)
Lines 323-329 __END__ Link Here
323
323
324
=head1 NAME
324
=head1 NAME
325
325
326
C4::Creators::PDF -   A class wrapper for PDF::Reuse and PDF::Reuse::Barcode to allow usage as a psuedo-object. For usage see
326
C4::Creators::PDF -   A class wrapper for PDF::Reuse and PDF::Reuse::Barcode to allow usage as a pseudo-object. For usage see
327
                    PDF::Reuse documentation and C4::Creators::PDF code.
327
                    PDF::Reuse documentation and C4::Creators::PDF code.
328
328
329
=cut
329
=cut
(-)a/C4/Creators/Profile.pm (-2 / +2 lines)
Lines 110-117 sub delete { Link Here
110
        push @params, $opts{'profile_id'}, $opts{'creator'};
110
        push @params, $opts{'profile_id'}, $opts{'creator'};
111
    }
111
    }
112
    if (scalar(@params) < 2) {   # If there is no profile id or creator type then we cannot delete it
112
    if (scalar(@params) < 2) {   # If there is no profile id or creator type then we cannot delete it
113
        warn sprintf('%s : Cannot delete profile as the profile id is invalid or non-existant.', $call_type) if !$params[0];
113
        warn sprintf('%s : Cannot delete profile as the profile id is invalid or non-existent.', $call_type) if !$params[0];
114
        warn sprintf('%s : Cannot delete profile as the creator type is invalid or non-existant.', $call_type) if !$params[1];
114
        warn sprintf('%s : Cannot delete profile as the creator type is invalid or non-existent.', $call_type) if !$params[1];
115
        return -1;
115
        return -1;
116
    }
116
    }
117
    my $query = "DELETE FROM printers_profile WHERE profile_id = ? AND creator = ?";
117
    my $query = "DELETE FROM printers_profile WHERE profile_id = ? AND creator = ?";
(-)a/C4/Creators/Template.pm (-3 / +3 lines)
Lines 150-157 sub delete { Link Here
150
        push @query_params, $opts{'template_id'}, $opts{'creator'};
150
        push @query_params, $opts{'template_id'}, $opts{'creator'};
151
    }
151
    }
152
    if (scalar(@query_params) < 2) {   # If there is no template id or creator type then we cannot delete it
152
    if (scalar(@query_params) < 2) {   # If there is no template id or creator type then we cannot delete it
153
        warn sprintf('%s : Cannot delete template as the template id is invalid or non-existant.', $call_type) if !$query_params[0];
153
        warn sprintf('%s : Cannot delete template as the template id is invalid or non-existent.', $call_type) if !$query_params[0];
154
        warn sprintf('%s : Cannot delete template as the creator type is invalid or non-existant.', $call_type) if !$query_params[1];
154
        warn sprintf('%s : Cannot delete template as the creator type is invalid or non-existent.', $call_type) if !$query_params[1];
155
        return -1;
155
        return -1;
156
    }
156
    }
157
    my $query = "DELETE FROM creator_templates WHERE template_id = ? AND creator = ?";
157
    my $query = "DELETE FROM creator_templates WHERE template_id = ? AND creator = ?";
Lines 344-350 CM = SI Centimeters (28.3464567 points per) Link Here
344
        my $template = C4::Labels::Template->new(profile_id => 1, page_width => 8.5, page_height => 11.0, units => 'INCH'); # Creates and returns a new template object using
344
        my $template = C4::Labels::Template->new(profile_id => 1, page_width => 8.5, page_height => 11.0, units => 'INCH'); # Creates and returns a new template object using
345
            the supplied values to override the defaults
345
            the supplied values to override the defaults
346
346
347
    B<NOTE:> This template is I<not> written to the database untill save() is invoked. You have been warned!
347
    B<NOTE:> This template is I<not> written to the database until save() is invoked. You have been warned!
348
348
349
=head2 retrieve(template_id => $template_id)
349
=head2 retrieve(template_id => $template_id)
350
350
(-)a/C4/Dates.pm (-2 / +2 lines)
Lines 279-285 date format unless otherwise instructed. Link Here
279
With no argument, format returns the object's current date_format.  Otherwise it attempts to 
279
With no argument, format returns the object's current date_format.  Otherwise it attempts to 
280
set the object format to the supplied value.
280
set the object format to the supplied value.
281
281
282
Some previously desireable functions are now unnecessary.  For example, you might want a 
282
Some previously desirable functions are now unnecessary.  For example, you might want a
283
method/function to tell you whether or not a Dates.pm object is of the 'iso' type.  But you 
283
method/function to tell you whether or not a Dates.pm object is of the 'iso' type.  But you 
284
can see by this example that such a test is trivial to accomplish, and not necessary to 
284
can see by this example that such a test is trivial to accomplish, and not necessary to 
285
include in the module:
285
include in the module:
Lines 315-321 Or even: Link Here
315
315
316
Perhaps you want to force data obtained in a known format to display according to the user's system
316
Perhaps you want to force data obtained in a known format to display according to the user's system
317
preference, without necessarily knowing what that preference is.  For this purpose, you can use the
317
preference, without necessarily knowing what that preference is.  For this purpose, you can use the
318
psuedo-format argument "syspref".  
318
pseudo-format argument "syspref".
319
319
320
For example, to print an ISO date (from the database) in the <systempreference> format:
320
For example, to print an ISO date (from the database) in the <systempreference> format:
321
321
(-)a/C4/Installer.pm (-1 / +1 lines)
Lines 458-464 sub load_sql { Link Here
458
        $error = qx($strcmd -f $filename 2>&1 1>/dev/null);
458
        $error = qx($strcmd -f $filename 2>&1 1>/dev/null);
459
        # Be sure to set 'client_min_messages = error' in postgresql.conf
459
        # Be sure to set 'client_min_messages = error' in postgresql.conf
460
        # so that only true errors are returned to stderr or else the installer will
460
        # so that only true errors are returned to stderr or else the installer will
461
        # report the import a failure although it really succeded -fbcit
461
        # report the import as a failure although it really succeeded -fbcit
462
    }
462
    }
463
#   errors thrown while loading installer data should be logged
463
#   errors thrown while loading installer data should be logged
464
    if($error) {
464
    if($error) {
(-)a/C4/Items.pm (-3 / +3 lines)
Lines 432-438 other purposes, C<ModItem> should be used. Link Here
432
432
433
This function uses the hash %default_values_for_mod_from_marc,
433
This function uses the hash %default_values_for_mod_from_marc,
434
which contains default values for item fields to
434
which contains default values for item fields to
435
apply when modifying an item.  This is needed beccause
435
apply when modifying an item.  This is needed because
436
if an item field's value is cleared, TransformMarcToKoha
436
if an item field's value is cleared, TransformMarcToKoha
437
does not include the column in the
437
does not include the column in the
438
hash that's passed to ModItem, which without
438
hash that's passed to ModItem, which without
Lines 791-797 C<items.notforloan> field. Link Here
791
NOTE: does B<not> return an individual item's
791
NOTE: does B<not> return an individual item's
792
status.
792
status.
793
793
794
Can be MARC dependant.
794
Can be MARC dependent.
795
fwkcode is optional.
795
fwkcode is optional.
796
But basically could be can be loan or not
796
But basically could be can be loan or not
797
Create a status selector with the following code
797
Create a status selector with the following code
Lines 2310-2316 sub DelItemCheck { Link Here
2310
        $error = "not_same_branch";
2310
        $error = "not_same_branch";
2311
    }
2311
    }
2312
	else{
2312
	else{
2313
        # check it doesnt have a waiting reserve
2313
        # check it doesn't have a waiting reserve
2314
        $sth = $dbh->prepare(q{
2314
        $sth = $dbh->prepare(q{
2315
            SELECT COUNT(*) FROM reserves
2315
            SELECT COUNT(*) FROM reserves
2316
            WHERE (found = 'W' OR found = 'T')
2316
            WHERE (found = 'W' OR found = 'T')
(-)a/C4/Koha.pm (-2 / +2 lines)
Lines 1741-1747 sub NormalizeISBN { Link Here
1741
1741
1742
  my @isbns = GetVariationsOfISBN( $isbn );
1742
  my @isbns = GetVariationsOfISBN( $isbn );
1743
1743
1744
  Returns a list of varations of the given isbn in
1744
  Returns a list of variations of the given isbn in
1745
  both ISBN-10 and ISBN-13 formats, with and without
1745
  both ISBN-10 and ISBN-13 formats, with and without
1746
  hyphens.
1746
  hyphens.
1747
1747
Lines 1773-1779 sub GetVariationsOfISBN { Link Here
1773
1773
1774
  my @isbns = GetVariationsOfISBNs( @isbns );
1774
  my @isbns = GetVariationsOfISBNs( @isbns );
1775
1775
1776
  Returns a list of varations of the given isbns in
1776
  Returns a list of variations of the given isbns in
1777
  both ISBN-10 and ISBN-13 formats, with and without
1777
  both ISBN-10 and ISBN-13 formats, with and without
1778
  hyphens.
1778
  hyphens.
1779
1779
(-)a/C4/Labels/Label.pm (-1 / +1 lines)
Lines 636-642 This module provides methods for creating, and otherwise manipulating single lab Link Here
636
            CODE39MOD10     = Code 3 of 9 with modulo 10 checksum
636
            CODE39MOD10     = Code 3 of 9 with modulo 10 checksum
637
637
638
=item .
638
=item .
639
            COOP2OF5        = A varient of 2 of 5 barcode based on NEC's "Process 8000" code
639
            COOP2OF5        = A variant of 2 of 5 barcode based on NEC's "Process 8000" code
640
640
641
=item .
641
=item .
642
            INDUSTRIAL2OF5  = The standard 2 of 5 barcode (a binary level bar code developed by Identicon Corp. and Computer Identics Corp. in 1970)
642
            INDUSTRIAL2OF5  = The standard 2 of 5 barcode (a binary level bar code developed by Identicon Corp. and Computer Identics Corp. in 1970)
(-)a/C4/Patroncards/Lib.pm (-2 / +2 lines)
Lines 198-204 This library provides functions used by various sections of the Patroncard Creat Link Here
198
198
199
=head2 C4::Patroncards::Lib::unpack_UTF8()
199
=head2 C4::Patroncards::Lib::unpack_UTF8()
200
200
201
    This function returns a reference to an array of hex values equivelant to the utf8 values of the string passed in. This assumes, of course, that the string is
201
    This function returns a reference to an array of hex values equivalent to the utf8 values of the string passed in. This assumes, of course, that the string is
202
    indeed utf8.
202
    indeed utf8.
203
203
204
    example:
204
    example:
Lines 235-241 This library provides functions used by various sections of the Patroncard Creat Link Here
235
235
236
=head2 C4::Patroncards::Lib::leading()
236
=head2 C4::Patroncards::Lib::leading()
237
237
238
    This function accepts a single parameter, font postscript point size, and returns the ammount of leading to be added.
238
    This function accepts a single parameter, font postscript point size, and returns the amount of leading to be added.
239
239
240
    example:
240
    example:
241
241
(-)a/C4/Ratings.pm (-1 / +1 lines)
Lines 72-78 Delete a rating for a bib Link Here
72
72
73
All subroutines in Ratings.pm return a hashref which contain 4 keys
73
All subroutines in Ratings.pm return a hashref which contain 4 keys
74
74
75
for example, after executing this statment below...
75
for example, after executing this statement below...
76
76
77
    my $rating_hashref = GetRating ( $biblionumber, $borrowernumber ) ;
77
    my $rating_hashref = GetRating ( $biblionumber, $borrowernumber ) ;
78
78
(-)a/C4/Reports/Guided.pm (-3 / +3 lines)
Lines 185-191 This will return a list of all columns for a report area Link Here
185
185
186
sub get_columns {
186
sub get_columns {
187
187
188
    # this calls the internal fucntion _get_columns
188
    # this calls the internal function _get_columns
189
    my ( $area, $cgi ) = @_;
189
    my ( $area, $cgi ) = @_;
190
    my %table_areas = get_table_areas;
190
    my %table_areas = get_table_areas;
191
    my $tables = $table_areas{$area}
191
    my $tables = $table_areas{$area}
Lines 440-446 for the query. Link Here
440
C<$offset>, and C<$limit> are required parameters.
440
C<$offset>, and C<$limit> are required parameters.
441
441
442
C<\@sql_params> is an optional list of parameter values to paste in.
442
C<\@sql_params> is an optional list of parameter values to paste in.
443
The caller is reponsible for making sure that C<$sql> has placeholders
443
The caller is responsible for making sure that C<$sql> has placeholders
444
and that the number placeholders matches the number of parameters.
444
and that the number placeholders matches the number of parameters.
445
445
446
=cut
446
=cut
Lines 783-789 sub get_column_type { Link Here
783
	my $catalog;
783
	my $catalog;
784
	my $schema;
784
	my $schema;
785
785
786
	# mysql doesnt support a column selection, set column to %
786
	# mysql doesn't support a column selection, set column to %
787
	my $tempcolumn='%';
787
	my $tempcolumn='%';
788
	my $sth = $dbh->column_info( $catalog, $schema, $table, $tempcolumn ) || die $dbh->errstr;
788
	my $sth = $dbh->column_info( $catalog, $schema, $table, $tempcolumn ) || die $dbh->errstr;
789
	while (my $info = $sth->fetchrow_hashref()){
789
	while (my $info = $sth->fetchrow_hashref()){
(-)a/C4/Reserves.pm (-8 / +8 lines)
Lines 61-67 This modules provides somes functions to deal with reservations. Link Here
61
  The following columns contains important values :
61
  The following columns contains important values :
62
  - priority >0      : then the reserve is at 1st stage, and not yet affected to any item.
62
  - priority >0      : then the reserve is at 1st stage, and not yet affected to any item.
63
             =0      : then the reserve is being dealed
63
             =0      : then the reserve is being dealed
64
  - found : NULL       : means the patron requested the 1st available, and we haven't choosen the item
64
  - found : NULL       : means the patron requested the 1st available, and we haven't chosen the item
65
            T(ransit)  : the reserve is linked to an item but is in transit to the pickup branch
65
            T(ransit)  : the reserve is linked to an item but is in transit to the pickup branch
66
            W(aiting)  : the reserve is linked to an item, is at the pickup branch, and is waiting on the hold shelf
66
            W(aiting)  : the reserve is linked to an item, is at the pickup branch, and is waiting on the hold shelf
67
            F(inished) : the reserve has been completed, and is done
67
            F(inished) : the reserve has been completed, and is done
Lines 74-80 This modules provides somes functions to deal with reservations. Link Here
74
         if there is no transfer to do, the reserve waiting
74
         if there is no transfer to do, the reserve waiting
75
         patron can pick it up                                    P =0, F=W,    I=filled
75
         patron can pick it up                                    P =0, F=W,    I=filled
76
         if there is a transfer to do, write in branchtransfer    P =0, F=T,    I=filled
76
         if there is a transfer to do, write in branchtransfer    P =0, F=T,    I=filled
77
           The pickup library recieve the book, it check in       P =0, F=W,    I=filled
77
           The pickup library receive the book, it check in       P =0, F=W,    I=filled
78
  The patron borrow the book                                      P =0, F=F,    I=filled
78
  The patron borrow the book                                      P =0, F=F,    I=filled
79
79
80
  ==== 2nd use case ====
80
  ==== 2nd use case ====
Lines 660-666 sub GetReserveCount { Link Here
660
660
661
  ($messages,$nextreservinfo)=$GetOtherReserves(itemnumber);
661
  ($messages,$nextreservinfo)=$GetOtherReserves(itemnumber);
662
662
663
Check queued list of this document and check if this document must be  transfered
663
Check queued list of this document and check if this document must be transferred
664
664
665
=cut
665
=cut
666
666
Lines 1386-1392 sub ModReserveAffect { Link Here
1386
    my $request = GetReserveInfo($reserve_id);
1386
    my $request = GetReserveInfo($reserve_id);
1387
    my $already_on_shelf = ($request && $request->{found} eq 'W') ? 1 : 0;
1387
    my $already_on_shelf = ($request && $request->{found} eq 'W') ? 1 : 0;
1388
1388
1389
    # If we affect a reserve that has to be transfered, don't set to Waiting
1389
    # If we affect a reserve that has to be transferred, don't set to Waiting
1390
    my $query;
1390
    my $query;
1391
    if ($transferToDo) {
1391
    if ($transferToDo) {
1392
    $query = "
1392
    $query = "
Lines 1591-1597 sub _get_itype { Link Here
1591
1591
1592
    my $itype;
1592
    my $itype;
1593
    if (C4::Context->preference('item-level_itypes')) {
1593
    if (C4::Context->preference('item-level_itypes')) {
1594
        # We cant trust GetItem to honour the syspref, so safest to do it ourselves
1594
        # We can't trust GetItem to honour the syspref, so safest to do it ourselves
1595
        # When GetItem is fixed, we can remove this
1595
        # When GetItem is fixed, we can remove this
1596
        $itype = $item->{itype};
1596
        $itype = $item->{itype};
1597
    }
1597
    }
Lines 1920-1926 sub _Findgroupreserve { Link Here
1920
    my $dbh   = C4::Context->dbh;
1920
    my $dbh   = C4::Context->dbh;
1921
1921
1922
    # TODO: consolidate at least the SELECT portion of the first 2 queries to a common $select var.
1922
    # TODO: consolidate at least the SELECT portion of the first 2 queries to a common $select var.
1923
    # check for exact targetted match
1923
    # check for exact targeted match
1924
    my $item_level_target_query = qq{
1924
    my $item_level_target_query = qq{
1925
        SELECT reserves.biblionumber        AS biblionumber,
1925
        SELECT reserves.biblionumber        AS biblionumber,
1926
               reserves.borrowernumber      AS borrowernumber,
1926
               reserves.borrowernumber      AS borrowernumber,
Lines 1954-1960 sub _Findgroupreserve { Link Here
1954
    }
1954
    }
1955
    return @results if @results;
1955
    return @results if @results;
1956
1956
1957
    # check for title-level targetted match
1957
    # check for title-level targeted match
1958
    my $title_level_target_query = qq{
1958
    my $title_level_target_query = qq{
1959
        SELECT reserves.biblionumber        AS biblionumber,
1959
        SELECT reserves.biblionumber        AS biblionumber,
1960
               reserves.borrowernumber      AS borrowernumber,
1960
               reserves.borrowernumber      AS borrowernumber,
Lines 2174-2180 sub OPACItemHoldsAllowed { Link Here
2174
    my $itype;
2174
    my $itype;
2175
    my $dbh = C4::Context->dbh;
2175
    my $dbh = C4::Context->dbh;
2176
    if (C4::Context->preference('item-level_itypes')) {
2176
    if (C4::Context->preference('item-level_itypes')) {
2177
       # We cant trust GetItem to honour the syspref, so safest to do it ourselves
2177
       # We can't trust GetItem to honour the syspref, so safest to do it ourselves
2178
       # When GetItem is fixed, we can remove this
2178
       # When GetItem is fixed, we can remove this
2179
       $itype = $item->{itype};
2179
       $itype = $item->{itype};
2180
    }
2180
    }
(-)a/C4/Ris.pm (-2 / +2 lines)
Lines 299-305 sub marc2ris { Link Here
299
299
300
##********************************************************************
300
##********************************************************************
301
## print_typetag(): prints the first line of a RIS dataset including
301
## print_typetag(): prints the first line of a RIS dataset including
302
## the preceeding newline
302
## the preceding newline
303
## Argument: the leader of a MARC dataset
303
## Argument: the leader of a MARC dataset
304
## Returns: the value at leader position 06 
304
## Returns: the value at leader position 06 
305
##********************************************************************
305
##********************************************************************
Lines 713-719 sub print_pubinfo { Link Here
713
		$protoyear =~ s% *[\.;:/]*$%%;
713
		$protoyear =~ s% *[\.;:/]*$%%;
714
714
715
		## isolate a four-digit year. We discard anything
715
		## isolate a four-digit year. We discard anything
716
		## preceeding the year, but keep everything after
716
		## preceding the year, but keep everything after
717
		## the year as other info.
717
		## the year as other info.
718
		$protoyear =~ s%\D*([0-9\-]{4})(.*)%$1///$2%;
718
		$protoyear =~ s%\D*([0-9\-]{4})(.*)%$1///$2%;
719
719
(-)a/C4/RotatingCollections.pm (-8 / +8 lines)
Lines 88-94 sub CreateCollection { Link Here
88
    my $schema = Koha::Database->new()->schema();
88
    my $schema = Koha::Database->new()->schema();
89
    my $duplicate_titles = $schema->resultset('Collection')->count({ colTitle => $title });
89
    my $duplicate_titles = $schema->resultset('Collection')->count({ colTitle => $title });
90
90
91
    ## Check for all neccessary parameters
91
    ## Check for all necessary parameters
92
    if ( !$title ) {
92
    if ( !$title ) {
93
        return ( 0, 1, "NO_TITLE" );
93
        return ( 0, 1, "NO_TITLE" );
94
    } elsif ( $duplicate_titles ) {
94
    } elsif ( $duplicate_titles ) {
Lines 136-142 sub UpdateCollection { Link Here
136
    my $schema = Koha::Database->new()->schema();
136
    my $schema = Koha::Database->new()->schema();
137
    my $duplicate_titles = $schema->resultset('Collection')->count({ colTitle => $title,  -not => { colId => $colId } });
137
    my $duplicate_titles = $schema->resultset('Collection')->count({ colTitle => $title,  -not => { colId => $colId } });
138
138
139
    ## Check for all neccessary parameters
139
    ## Check for all necessary parameters
140
    if ( !$colId ) {
140
    if ( !$colId ) {
141
        return ( 0, 1, "NO_ID" );
141
        return ( 0, 1, "NO_ID" );
142
    }
142
    }
Lines 171-177 sub UpdateCollection { Link Here
171
 Deletes a collection of the given id
171
 Deletes a collection of the given id
172
172
173
 Input:
173
 Input:
174
   $colId : id of the Archtype to be deleted
174
   $colId : id of the Archetype to be deleted
175
175
176
 Output:
176
 Output:
177
   $success: 1 if all database operations were successful, 0 otherwise
177
   $success: 1 if all database operations were successful, 0 otherwise
Lines 183-189 sub UpdateCollection { Link Here
183
sub DeleteCollection {
183
sub DeleteCollection {
184
    my ($colId) = @_;
184
    my ($colId) = @_;
185
185
186
    ## Paramter check
186
    ## Parameter check
187
    if ( !$colId ) {
187
    if ( !$colId ) {
188
        return ( 0, 1, "NO_ID" );
188
        return ( 0, 1, "NO_ID" );
189
    }
189
    }
Lines 247-253 sub GetCollections { Link Here
247
sub GetItemsInCollection {
247
sub GetItemsInCollection {
248
    my ($colId) = @_;
248
    my ($colId) = @_;
249
249
250
    ## Paramter check
250
    ## Parameter check
251
    if ( !$colId ) {
251
    if ( !$colId ) {
252
        return ( 0, 0, 1, "NO_ID" );
252
        return ( 0, 0, 1, "NO_ID" );
253
    }
253
    }
Lines 326-332 Adds an item to a rotating collection. Link Here
326
sub AddItemToCollection {
326
sub AddItemToCollection {
327
    my ( $colId, $itemnumber ) = @_;
327
    my ( $colId, $itemnumber ) = @_;
328
328
329
    ## Check for all neccessary parameters
329
    ## Check for all necessary parameters
330
    if ( !$colId ) {
330
    if ( !$colId ) {
331
        return ( 0, 1, "NO_ID" );
331
        return ( 0, 1, "NO_ID" );
332
    }
332
    }
Lines 376-382 Removes an item to a collection Link Here
376
sub RemoveItemFromCollection {
376
sub RemoveItemFromCollection {
377
    my ( $colId, $itemnumber ) = @_;
377
    my ( $colId, $itemnumber ) = @_;
378
378
379
    ## Check for all neccessary parameters
379
    ## Check for all necessary parameters
380
    if ( !$itemnumber ) {
380
    if ( !$itemnumber ) {
381
        return ( 0, 2, "NO_ITEM" );
381
        return ( 0, 2, "NO_ITEM" );
382
    }
382
    }
Lines 417-423 Transfers a collection to another branch Link Here
417
sub TransferCollection {
417
sub TransferCollection {
418
    my ( $colId, $colBranchcode ) = @_;
418
    my ( $colId, $colBranchcode ) = @_;
419
419
420
    ## Check for all neccessary parameters
420
    ## Check for all necessary parameters
421
    if ( !$colId ) {
421
    if ( !$colId ) {
422
        return ( 0, 1, "NO_ID" );
422
        return ( 0, 1, "NO_ID" );
423
    }
423
    }
(-)a/C4/SIP/ILS/Patron.pod (-2 / +2 lines)
Lines 95-101 explication however. Link Here
95
95
96
=head2 C<$str = $patron-E<gt>sip_birthdate;>
96
=head2 C<$str = $patron-E<gt>sip_birthdate;>
97
97
98
Returns the patron's birthday formated according to the SIP
98
Returns the patron's birthday formatted according to the SIP
99
specification:
99
specification:
100
100
101
	YYYYMMDD    HHMMSS
101
	YYYYMMDD    HHMMSS
Lines 112-118 based on patron type). Link Here
112
112
113
=head2 C<$str = $patron-E<gt>language;>
113
=head2 C<$str = $patron-E<gt>language;>
114
114
115
A three-digit string encoding the patron's prefered language.
115
A three-digit string encoding the patron's preferred language.
116
The full list is defined in the SIP specification, but some of
116
The full list is defined in the SIP specification, but some of
117
the important values are:
117
the important values are:
118
118
(-)a/C4/SIP/Sip.pm (-1 / +1 lines)
Lines 74-80 sub add_field { Link Here
74
    $value=~s/\r/ /g; # CR terminates a sip message
74
    $value=~s/\r/ /g; # CR terminates a sip message
75
                      # Protect against them in sip text fields
75
                      # Protect against them in sip text fields
76
76
77
    # Replace any occurences of the field delimiter in the
77
    # Replace any occurrences of the field delimiter in the
78
    # field value with the HTML character entity
78
    # field value with the HTML character entity
79
    $ent = sprintf("&#%d;", ord($field_delimiter));
79
    $ent = sprintf("&#%d;", ord($field_delimiter));
80
80
(-)a/C4/SIP/Sip/MsgType.pm (-4 / +4 lines)
Lines 836-842 sub login_core { Link Here
836
			#
836
			#
837
			my $module = $server->{config}->{institutions}->{$inst}->{implementation};
837
			my $module = $server->{config}->{institutions}->{$inst}->{implementation};
838
			syslog("LOG_DEBUG", 'login_core: ' . Dumper($module));
838
			syslog("LOG_DEBUG", 'login_core: ' . Dumper($module));
839
            # Suspect this is always ILS but so we dont break any eccentic install (for now)
839
            # Suspect this is always ILS but so we don't break any eccentic install (for now)
840
            if ($module eq 'ILS') {
840
            if ($module eq 'ILS') {
841
                $module = 'C4::SIP::ILS';
841
                $module = 'C4::SIP::ILS';
842
            }
842
            }
Lines 885-891 sub handle_login { Link Here
885
#
885
#
886
# Build the detailed summary information for the Patron
886
# Build the detailed summary information for the Patron
887
# Information Response message based on the first 'Y' that appears
887
# Information Response message based on the first 'Y' that appears
888
# in the 'summary' field of the Patron Information reqest.  The
888
# in the 'summary' field of the Patron Information request.  The
889
# specification says that only one 'Y' can appear in that field,
889
# specification says that only one 'Y' can appear in that field,
890
# and we're going to believe it.
890
# and we're going to believe it.
891
#
891
#
Lines 1343-1349 sub handle_renew { Link Here
1343
1343
1344
    if ($no_block eq 'Y') {
1344
    if ($no_block eq 'Y') {
1345
	syslog("LOG_WARNING",
1345
	syslog("LOG_WARNING",
1346
	       "handle_renew: recieved 'no block' renewal from terminal '%s'",
1346
	       "handle_renew: received 'no block' renewal from terminal '%s'",
1347
	       $server->{account}->{id});
1347
	       $server->{account}->{id});
1348
    }
1348
    }
1349
1349
Lines 1391-1397 sub handle_renew { Link Here
1391
	$resp .= '0NUN';
1391
	$resp .= '0NUN';
1392
	$resp .= timestamp;
1392
	$resp .= timestamp;
1393
	# If we found the patron or the item, the return the ILS
1393
	# If we found the patron or the item, the return the ILS
1394
	# information, otherwise echo back the infomation we received
1394
	# information, otherwise echo back the information we received
1395
	# from the terminal
1395
	# from the terminal
1396
	$resp .= add_field(FID_PATRON_ID, $patron ? $patron->id     : $patron_id);
1396
	$resp .= add_field(FID_PATRON_ID, $patron ? $patron->id     : $patron_id);
1397
	$resp .= add_field(FID_ITEM_ID,     $item ? $item->id       : $item_id  );
1397
	$resp .= add_field(FID_ITEM_ID,     $item ? $item->id       : $item_id  );
(-)a/C4/Search.pm (-2 / +2 lines)
Lines 171-177 This function provides a simple search API on the bibliographic catalog Link Here
171
171
172
    * $query can be a simple keyword or a complete CCL query
172
    * $query can be a simple keyword or a complete CCL query
173
    * @servers is optional. Defaults to biblioserver as found in koha-conf.xml
173
    * @servers is optional. Defaults to biblioserver as found in koha-conf.xml
174
    * $offset - If present, represents the number of records at the beggining to omit. Defaults to 0
174
    * $offset - If present, represents the number of records at the beginning to omit. Defaults to 0
175
    * $max_results - if present, determines the maximum number of records to fetch. undef is All. defaults to undef.
175
    * $max_results - if present, determines the maximum number of records to fetch. undef is All. defaults to undef.
176
176
177
177
Lines 922-928 sub _remove_stopwords { Link Here
922
922
923
# remove stopwords from operand : parse all stopwords & remove them (case insensitive)
923
# remove stopwords from operand : parse all stopwords & remove them (case insensitive)
924
#       we use IsAlpha unicode definition, to deal correctly with diacritics.
924
#       we use IsAlpha unicode definition, to deal correctly with diacritics.
925
#       otherwise, a French word like "leçon" woudl be split into "le" "çon", "le"
925
#       otherwise, a French word like "leçon" would be split into "le" "çon", "le"
926
#       is a stopword, we'd get "çon" and wouldn't find anything...
926
#       is a stopword, we'd get "çon" and wouldn't find anything...
927
#
927
#
928
		foreach ( keys %{ C4::Context->stopwords } ) {
928
		foreach ( keys %{ C4::Context->stopwords } ) {
(-)a/C4/Serials.pm (-3 / +3 lines)
Lines 2584-2590 sub _numeration { Link Here
2584
2584
2585
=head2 is_barcode_in_use
2585
=head2 is_barcode_in_use
2586
2586
2587
Returns number of occurence of the barcode in the items table
2587
Returns number of occurrences of the barcode in the items table
2588
Can be used as a boolean test of whether the barcode has
2588
Can be used as a boolean test of whether the barcode has
2589
been deployed as yet
2589
been deployed as yet
2590
2590
Lines 2593-2605 been deployed as yet Link Here
2593
sub is_barcode_in_use {
2593
sub is_barcode_in_use {
2594
    my $barcode = shift;
2594
    my $barcode = shift;
2595
    my $dbh       = C4::Context->dbh;
2595
    my $dbh       = C4::Context->dbh;
2596
    my $occurences = $dbh->selectall_arrayref(
2596
    my $occurrences = $dbh->selectall_arrayref(
2597
        'SELECT itemnumber from items where barcode = ?',
2597
        'SELECT itemnumber from items where barcode = ?',
2598
        {}, $barcode
2598
        {}, $barcode
2599
2599
2600
    );
2600
    );
2601
2601
2602
    return @{$occurences};
2602
    return @{$occurrences};
2603
}
2603
}
2604
2604
2605
=head2 CloseSubscription
2605
=head2 CloseSubscription
(-)a/C4/Serials/Frequency.pm (-1 / +1 lines)
Lines 287-292 __END__ Link Here
287
287
288
=head1 AUTHOR
288
=head1 AUTHOR
289
289
290
Koha Developement team <info@koha.org>
290
Koha Development team <info@koha.org>
291
291
292
=cut
292
=cut
(-)a/C4/Serials/Numberpattern.pm (-1 / +1 lines)
Lines 284-289 __END__ Link Here
284
284
285
=head1 AUTHOR
285
=head1 AUTHOR
286
286
287
Koha Developement team <info@koha.org>
287
Koha Development team <info@koha.org>
288
288
289
=cut
289
=cut
(-)a/C4/ShelfBrowser.pm (-1 / +1 lines)
Lines 103-109 C<ShelfBrowserUsesCcode>. Link Here
103
The option C<$num_each_side> value determines how many items will be fetched
103
The option C<$num_each_side> value determines how many items will be fetched
104
each side of the supplied item. Note that the item itself is the first entry
104
each side of the supplied item. Note that the item itself is the first entry
105
in the 'next' set, and counts towards this limit (this is to keep the
105
in the 'next' set, and counts towards this limit (this is to keep the
106
behaviour consistant with the code that this is a refactor of.) Default is
106
behaviour consistent with the code that this is a refactor of.) Default is
107
3.
107
3.
108
108
109
This will throw an exception if something went wrong.
109
This will throw an exception if something went wrong.
(-)a/C4/TTParser.pm (-4 / +4 lines)
Lines 55-63 sub peep_token{ Link Here
55
sub build_tokens{
55
sub build_tokens{
56
    my ($self, $filename) = @_;
56
    my ($self, $filename) = @_;
57
    $self->{filename} = $filename;
57
    $self->{filename} = $filename;
58
    $self->handler(start => "start", "self, line, tagname, attr, text"); #signature is start( self, linenumber, tagname, hash of attributes, origional text )
58
    $self->handler(start => "start", "self, line, tagname, attr, text"); #signature is start( self, linenumber, tagname, hash of attributes, original text )
59
    $self->handler(text => "text", "self, line, text, is_cdata"); #signature is text( self, linenumber, origional text, is_cdata )
59
    $self->handler(text => "text", "self, line, text, is_cdata"); #signature is text( self, linenumber, original text, is_cdata )
60
    $self->handler(end => "end", "self, line, tag, attr, text"); #signature is end( self, linenumber, tagename, origional text )
60
    $self->handler(end => "end", "self, line, tag, attr, text"); #signature is end( self, linenumber, tagename, original text )
61
    $self->handler(declaration => "declaration", "self, line, text, is_cdata"); # declaration
61
    $self->handler(declaration => "declaration", "self, line, text, is_cdata"); # declaration
62
    $self->handler(comment => "comment", "self, line, text, is_cdata"); # comments
62
    $self->handler(comment => "comment", "self, line, text, is_cdata"); # comments
63
#    $self->handler(default => "default", "self, line, text, is_cdata"); # anything else
63
#    $self->handler(default => "default", "self, line, text, is_cdata"); # anything else
Lines 132-138 sub start{ Link Here
132
    my $line = shift;
132
    my $line = shift;
133
    my $tag = shift;
133
    my $tag = shift;
134
    my $hash = shift; #hash of attr/value pairs
134
    my $hash = shift; #hash of attr/value pairs
135
    my $text = shift; #origional text
135
    my $text = shift; #original text
136
    my $t = C4::TmplToken->new( $text, C4::TmplTokenType::TAG, $line, $self->{filename});
136
    my $t = C4::TmplToken->new( $text, C4::TmplTokenType::TAG, $line, $self->{filename});
137
    my %attr;
137
    my %attr;
138
    # tags seem to be uses in an 'interesting' way elsewhere..
138
    # tags seem to be uses in an 'interesting' way elsewhere..
(-)a/C4/Tags.pm (-2 / +2 lines)
Lines 581-587 sub add_tag { # biblionumber,term,[borrowernumber,approvernumber] Link Here
581
#   ($min, $max) = stratify_tags($strata, $tags);
581
#   ($min, $max) = stratify_tags($strata, $tags);
582
# $stratum: the number of divisions you want
582
# $stratum: the number of divisions you want
583
# $tags: the tags, as provided by get_approval_rows
583
# $tags: the tags, as provided by get_approval_rows
584
# $min: the minumum stratum value
584
# $min: the minimum stratum value
585
# $max: the maximum stratum value. This may be the same as $min if there
585
# $max: the maximum stratum value. This may be the same as $min if there
586
# is only one weight. Beware of divide by zeros.
586
# is only one weight. Beware of divide by zeros.
587
# This will add a field to the tag called "stratum" containing the calculated
587
# This will add a field to the tag called "stratum" containing the calculated
Lines 666-672 This could be called an "approved terms" table. See above regarding the Externa Link Here
666
	approved       - Negative, 0 or positive if tag is rejected, pending or approved.
666
	approved       - Negative, 0 or positive if tag is rejected, pending or approved.
667
	date_approved  - date of last action
667
	date_approved  - date of last action
668
	approved_by    - staffer performing the last action
668
	approved_by    - staffer performing the last action
669
	weight_total   - total occurance of term in any biblio by any users
669
	weight_total   - total occurrence of term in any biblio by any users
670
670
671
tags_index - This table is for performance, because by far the most common operation will 
671
tags_index - This table is for performance, because by far the most common operation will 
672
be fetching tags for a list of search results.  We will have a set of biblios, and we will
672
be fetching tags for a list of search results.  We will have a set of biblios, and we will
(-)a/C4/UploadedFile.pm (-1 / +1 lines)
Lines 63-69 to survive beyond the life of the user's session. Link Here
63
This module allows for tracking the progress of the file
63
This module allows for tracking the progress of the file
64
currently being uploaded.
64
currently being uploaded.
65
65
66
TODO: implement secure persistant storage of uploaded files.
66
TODO: implement secure persistent storage of uploaded files.
67
67
68
=cut
68
=cut
69
69
(-)a/C4/Utils/DataTables/ColumnsSettings.pm (-1 / +1 lines)
Lines 11-17 sub get_yaml { Link Here
11
      C4::Context->config('intranetdir') . '/admin/columns_settings.yml';
11
      C4::Context->config('intranetdir') . '/admin/columns_settings.yml';
12
    my $yaml = eval { YAML::LoadFile($yml_path) };
12
    my $yaml = eval { YAML::LoadFile($yml_path) };
13
    warn
13
    warn
14
"ERROR: the yaml file for DT::ColumnsSettings is not correctly formated: $@"
14
"ERROR: the yaml file for DT::ColumnsSettings is not correctly formatted: $@"
15
      if $@;
15
      if $@;
16
    return $yaml;
16
    return $yaml;
17
}
17
}
(-)a/C4/Utils/DataTables/Members.pm (-1 / +1 lines)
Lines 22-28 sub search { Link Here
22
22
23
    my ($iTotalRecords, $iTotalDisplayRecords);
23
    my ($iTotalRecords, $iTotalDisplayRecords);
24
24
25
    # If branches are independant and user is not superlibrarian
25
    # If branches are independent and user is not superlibrarian
26
    # The search has to be only on the user branch
26
    # The search has to be only on the user branch
27
    if ( C4::Branch::onlymine ) {
27
    if ( C4::Branch::onlymine ) {
28
        my $userenv = C4::Context->userenv;
28
        my $userenv = C4::Context->userenv;
(-)a/C4/XSLT.pm (-2 / +1 lines)
Lines 100-106 sub transformMARCXML4XSLT { Link Here
100
100
101
=head2 getAuthorisedValues4MARCSubfields
101
=head2 getAuthorisedValues4MARCSubfields
102
102
103
Returns a ref of hash of ref of hash for tag -> letter controled by authorised values
103
Returns a ref of hash of ref of hash for tag -> letter controlled by authorised values
104
Is only used in this module currently.
104
Is only used in this module currently.
105
105
106
=cut
106
=cut
107
- 

Return to bug 14383