From 20cfb8af36484e753eea929d4c3034a629d79eec Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Sun, 7 Jun 2015 23:40:50 -0400 Subject: [PATCH] Bug 14362: Regression tests This should trigger the error. Attempting shifting system time zones did not make sense as to the number of failures. Added Time::Fake dependency, if it isn't installed these extra tests don't run. However, a diag message is given about the lacking dependency. TEST PLAN --------- 1) apply test patch 2) sudo dpkg-reconfigure tzdata -- set your system time to GMT 3) prove t/Circulation/AgeRestrictionMarkers.t -- should not fail, even if you change system time to any time. 4) sudo dpkg-reconfigure tzdata -- set your timezone to Eastern 5) sudo date -s"2015-06-18 21:15:00" 6) date -- should be past 9pm Eastern timezone 7) prove t/Circulation/AgeRestrictionMarkers.t -- kaboom! 8) sudo date -s"2015-06-18 12:00:00" 9) date -- should be noon Eastern timezone 10) prove t/Circulation/AgeRestrictionMarkers.t -- success?! Time sensitive tests are bad tests. 11) sudo apt-get install libtime-fake-perl 12) prove t/Circulation/AgetRestrictionMarkers.t -- kaboom! -- changing timezone to anything other than GMT should trigger a kaboom. 13) apply fix patch 14) prove t/Circulation/AgeRestrictionMarkers.t -- should work all the time. 15) koha qa test tools. --- C4/Installer/PerlDependencies.pm | 5 ++++ t/Circulation/AgeRestrictionMarkers.t | 55 ++++++++++++++++++++++++----------- 2 files changed, 43 insertions(+), 17 deletions(-) diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm index 57c5972..44544f5 100644 --- a/C4/Installer/PerlDependencies.pm +++ b/C4/Installer/PerlDependencies.pm @@ -737,6 +737,11 @@ our $PERL_DEPS = { 'required' => '0', 'min_ver' => '0.89', }, + 'Time::Fake' => { + 'usage' => 'Test code coverage', + 'required' => '0', + 'min_ver' => '0.11', + } }; 1; diff --git a/t/Circulation/AgeRestrictionMarkers.t b/t/Circulation/AgeRestrictionMarkers.t index 750bf9b..9d47a8b 100644 --- a/t/Circulation/AgeRestrictionMarkers.t +++ b/t/Circulation/AgeRestrictionMarkers.t @@ -1,8 +1,9 @@ #!/usr/bin/perl use Modern::Perl; + use DateTime; -use Test::More tests => 10; +use Test::More tests => 6; use t::lib::Mocks; @@ -10,25 +11,45 @@ use C4::Circulation; t::lib::Mocks::mock_preference( 'AgeRestrictionMarker', 'FSK|PEGI|Age|K' ); +$| = 1; is ( C4::Circulation::GetAgeRestriction('FSK 16'), '16', 'FSK 16 returns 16' ); is ( C4::Circulation::GetAgeRestriction('PEGI 16'), '16', 'PEGI 16 returns 16' ); is ( C4::Circulation::GetAgeRestriction('PEGI16'), '16', 'PEGI16 returns 16' ); is ( C4::Circulation::GetAgeRestriction('Age 16'), '16', 'Age 16 returns 16' ); is ( C4::Circulation::GetAgeRestriction('K16'), '16', 'K16 returns 16' ); - -##Testing age restriction for a borrower. -my $now = DateTime->now(); -my $borrower = {}; -C4::Members::SetAge( $borrower, '0015-00-00' ); - -my ($restriction_age, $daysToAgeRestriction) = C4::Circulation::GetAgeRestriction('FSK 16', $borrower); -is ( ($daysToAgeRestriction > 0), 1, 'FSK 16 blocked for a 15 year old' ); -($restriction_age, $daysToAgeRestriction) = C4::Circulation::GetAgeRestriction('PEGI 15', $borrower); -is ( ($daysToAgeRestriction <= 0), 1, 'PEGI 15 allowed for a 15 year old' ); -($restriction_age, $daysToAgeRestriction) = C4::Circulation::GetAgeRestriction('PEGI14', $borrower); -is ( ($daysToAgeRestriction <= 0), 1, 'PEGI14 allowed for a 15 year old' ); -($restriction_age, $daysToAgeRestriction) = C4::Circulation::GetAgeRestriction('Age 10', $borrower); -is ( ($daysToAgeRestriction <= 0), 1, 'Age 10 allowed for a 15 year old' ); -($restriction_age, $daysToAgeRestriction) = C4::Circulation::GetAgeRestriction('K18', $borrower); -is ( ($daysToAgeRestriction > 0), 1, 'K18 blocked for a 15 year old' ); \ No newline at end of file +subtest 'Patron tests - 15 years old' => sub { + my $MaxOffset; + my $CheckTimeFake = eval { require Time::Fake; 1; } || 0; + if ($CheckTimeFake==1) { + $MaxOffset = 24; + plan tests => 120; + } + else { + diag("Install Time::Fake to regression test for Bug 14362."); + $MaxOffset = 1; + plan tests => 5; + } + my $offset = 0; + while ($offset<$MaxOffset) { + if ($MaxOffset>1) { + Time::Fake->offset("+${offset}h"); + } + ##Testing age restriction for a borrower. + my $now = DateTime->now(); + my $borrower = {}; + C4::Members::SetAge( $borrower, '0015-00-00' ); + + my ($restriction_age, $daysToAgeRestriction) = C4::Circulation::GetAgeRestriction('FSK 16', $borrower); + is ( ($daysToAgeRestriction > 0), 1, "FSK 16 blocked for a 15 year old - $offset hours" ); + ($restriction_age, $daysToAgeRestriction) = C4::Circulation::GetAgeRestriction('PEGI 15', $borrower); + is ( ($daysToAgeRestriction <= 0), 1, "PEGI 15 allowed for a 15 year old - $offset hours" ); + ($restriction_age, $daysToAgeRestriction) = C4::Circulation::GetAgeRestriction('PEGI14', $borrower); + is ( ($daysToAgeRestriction <= 0), 1, "PEGI14 allowed for a 15 year old - $offset hours" ); + ($restriction_age, $daysToAgeRestriction) = C4::Circulation::GetAgeRestriction('Age 10', $borrower); + is ( ($daysToAgeRestriction <= 0), 1, "Age 10 allowed for a 15 year old - $offset hours" ); + ($restriction_age, $daysToAgeRestriction) = C4::Circulation::GetAgeRestriction('K18', $borrower); + is ( ($daysToAgeRestriction > 0), 1, "K18 blocked for a 15 year old - $offset hours" ); + $offset++; + } +} -- 2.1.4