From 68c8f6999053f416679e35791d49dcba3174f301 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 18 Jun 2015 20:50:53 -0400 Subject: [PATCH] Bug 13030 [QA Followup] - Fix unit tests --- t/{ => db_dependent}/Hold.t | 27 +++++++++++++-------------- 1 files changed, 13 insertions(+), 14 deletions(-) rename t/{ => db_dependent}/Hold.t (78%) diff --git a/t/Hold.t b/t/db_dependent/Hold.t similarity index 78% rename from t/Hold.t rename to t/db_dependent/Hold.t index 6594c56..0aa7076 100755 --- a/t/Hold.t +++ b/t/db_dependent/Hold.t @@ -17,29 +17,26 @@ use Modern::Perl; -use Test::MockModule; +use C4::Context; +use Koha::Database; + use Test::More tests => 5; -use t::lib::Mocks; - -my $module = new Test::MockModule('C4::Context'); -$module->mock( - '_new_dbh', - sub { - my $dbh = DBI->connect( 'DBI:Mock:', '', '' ) - || die "Cannot create handle: $DBI::errstr\n"; - return $dbh; - } -); use_ok('Koha::Hold'); +my $schema = Koha::Database->new()->schema(); +$schema->storage->txn_begin(); + +my $dbh = C4::Context->dbh; +$dbh->{RaiseError} = 1; + my $hold = Koha::Hold->new({ found => 'W', waitingdate => '2000-01-01'}); -t::lib::Mocks::mock_preference('ReservesMaxPickUpDelay', undef); +C4::Context->set_preference( 'ReservesMaxPickUpDelay', '' ); my $dt = $hold->waiting_expires_on(); is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if ReservesMaxPickUpDelay is not set"); -t::lib::Mocks::mock_preference('ReservesMaxPickUpDelay', 5); +C4::Context->set_preference( 'ReservesMaxPickUpDelay', '5' ); $dt = $hold->waiting_expires_on(); is( $dt->ymd, "2000-01-06", "Koha::Hold->waiting_expires_on returns DateTime of waitingdate + ReservesMaxPickUpDelay if set"); @@ -51,4 +48,6 @@ $hold->found(q{}); $dt = $hold->waiting_expires_on(); is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to empty string )"); +$schema->storage->txn_rollback(); + 1; -- 1.7.2.5