From 3ece53440feaedf371699e259ad6b911e016f553 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 25 Jun 2015 16:41:23 -0400 Subject: [PATCH] Bug 14467 - Security updates break some Koha plugins The new security updates break previously functioning plugins, most notably the cover flow plugin and the Ebsco EDS plugin. Test Plan: 1) Install and configure the cover flow plugin ( http://bywatersolutions.com/koha-plugins/ ) 2) Note that attempting to access coverflow.pl from the OPAC results in an error 3) Apply this patch 4) Note that coverflow.pl now output html again Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Since Cwd is part of the Perl code modules, it's certainly useless to put it in the dependency list --- C4/Installer/PerlDependencies.pm | 5 +++++ Koha/Plugins/Base.pm | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm index 9ddeca8..0ec6c2d 100644 --- a/C4/Installer/PerlDependencies.pm +++ b/C4/Installer/PerlDependencies.pm @@ -647,6 +647,11 @@ our $PERL_DEPS = { 'required' => '0', 'min_ver' => '3.9', }, + 'Cwd' => { + 'usage' => 'Plugins', + 'required' => '0', + 'min_ver' => '3.47', + }, 'File::Slurp' => { 'usage' => 'Command line scripts', 'required' => '0', diff --git a/Koha/Plugins/Base.pm b/Koha/Plugins/Base.pm index f60343a..55e1e7b 100644 --- a/Koha/Plugins/Base.pm +++ b/Koha/Plugins/Base.pm @@ -20,6 +20,7 @@ package Koha::Plugins::Base; use Modern::Perl; use Module::Pluggable require => 1; +use Cwd qw(abs_path); use base qw{Module::Bundled::Files}; @@ -106,7 +107,7 @@ sub get_template { require C4::Auth; my ( $template, $loggedinuser, $cookie ) = C4::Auth::get_template_and_user( - { template_name => $self->mbf_path( $args->{'file'} ), + { template_name => abs_path( $self->mbf_path( $args->{'file'} ) ), query => $self->{'cgi'}, type => "intranet", authnotrequired => 1, -- 2.1.0