From f28a767a07174f948bff3ece87b96e55ab87688d Mon Sep 17 00:00:00 2001 From: Indranil Das Gupta Date: Fri, 3 Jul 2015 13:33:06 +0530 Subject: [PATCH] Bug 14487 - silence warns during checkin Test plan ========= 1/ check out an item and then check it back in. 1/ check the logs after the check-in to see the warns from returns.pl line 623 of : (a) Use of uninitialized value $holdingBranch (b) Use of uninitialized value $collectionBranch 2/ apply patch 3/ check out and check-in again. no warns are recorded this time. --- circ/returns.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/returns.pl b/circ/returns.pl index c36318f..bf1740b 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -620,7 +620,7 @@ $template->param( $itemnumber = GetItemnumberFromBarcode( $query->param('barcode') ); if ( $itemnumber ) { my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber ); - if ( ! ( $holdingBranch eq $collectionBranch ) ) { + if ( ! ( ($holdingBranch // '') eq ( $collectionBranch // '' ) ) ) { $template->param( collectionItemNeedsTransferred => 1, collectionBranch => GetBranchName($collectionBranch), -- 1.9.1