Bugzilla – Attachment 40789 Details for
Bug 14485
HTML comment disables translation in cataloguing/addbooks.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt
Bug-14485---HTML-comment-disables-translation-in-c.patch (text/plain), 2.13 KB, created by
Héctor Eduardo Castro Avalos
on 2015-07-04 06:02:57 UTC
(
hide
)
Description:
Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2015-07-04 06:02:57 UTC
Size:
2.13 KB
patch
obsolete
>From 1264dd0510e50e2ed4da433606e5a00101986339 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 2 Jul 2015 10:37:22 +0200 >Subject: [PATCH] Bug 14485 - HTML comment disables translation in > cataloguing/addbooks.tt > >In cataloguing/addbooks.tt, the line : > [% total %] result(s) found in catalog, >is not present in PO files even after an update. >I've found that the cause is the previous HTML comment line. > >This patch converts HTML comment into TT comment and adds a div to have a more comprehensive string to translate. > >Test plan : >- without patch >- go into <sources>/misc/translator >- run PO update for example in french : translate update fr-FR >=> the text "result(s) found in catalog" is missing from PO file : fr-FR-staff-prog.po >- restore default PO files >- apply patch >- go into <sources>/misc/translator >- run PO update for example in french : translate update fr-FR >=> You find text "result(s) found in catalog" in PO file : fr-FR-staff-prog.po > >Sponsored-by: Universidad de El Salvador > >Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> >Works as advertised. Just one msgid appear with msgid "%s result(s) found in catalog," >--- > .../intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >index 19e0e1c..affa0fe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >@@ -101,11 +101,13 @@ > No results found > [% END %] > >-<!-- display the search results --> >+[%# display the search results %] > > [% IF ( total ) %] >-[% total %] result(s) found in catalog, >-<a href="#searchresult-breeding">[% breeding_count %] result(s) found in reservoir</a> >+<div> >+ [% total %] result(s) found in catalog, >+ <a href="#searchresult-breeding">[% breeding_count %] result(s) found in reservoir</a> >+</div> > <div class="pages">[% pagination_bar %]</div> > <div class="searchresults"> > <table> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14485
:
40754
|
40782
|
40789
|
40858