From c5390bc8ef763038c04445c10963b28f90965004 Mon Sep 17 00:00:00 2001 From: remi Date: Wed, 20 May 2015 13:26:23 -0400 Subject: [PATCH] Bug 14518 - Allow deleting notices with reservations (and no item) after confirmation Cleaning up notices with no item but reservation is impossible since the code does not consider the result from the confirmation popup. This situation happens to our client in their (annual) cleanup. I suppose those are notices for orders that never materialized, but people already made reservations on them. Test: 1) create (or find) a notice with no item. 2) make a reservation on it. 3) try to delete the notice. a) a popup will ask for confirmation b) after accepting, validate if the notice is deleted. --- koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc index ee39f31..8f44496 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc @@ -57,11 +57,7 @@ is_confirmed = confirm(_("Are you sure you want to delete this record?")); } if (is_confirmed) { - if ( count > 0 || holdcount > 0 ){ - return false; - } else { window.location="/cgi-bin/koha/cataloguing/addbiblio.pl?op=delete&biblionumber=[% biblionumber %]"; - } } else { return false; } -- 2.1.0