From 172f4b7d467b502629b35dd7caab3eba45c66c98 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 7 Jan 2015 15:29:50 +0100 Subject: [PATCH] Bug 12252: (qa-follow-up) Remove perlcritic error --- C4/Biblio.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index 48fff3b..c7bd159 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -2939,12 +2939,13 @@ sub EmbedItemsInMarcBiblio { require C4::Items; while ( my ($itemnumber) = $sth->fetchrow_array ) { next if @$itemnumbers and not grep { $_ == $itemnumber } @$itemnumbers; - my $i = C4::Items::GetItem($itemnumber) if $opachiddenitems; + my $i = $opachiddenitems ? C4::Items::GetItem($itemnumber) : undef; push @items, { itemnumber => $itemnumber, item => $i }; } my @hiddenitems = - C4::Items::GetHiddenItemnumbers( map { $_->{item} } @items ) - if $opachiddenitems; + $opachiddenitems + ? C4::Items::GetHiddenItemnumbers( map { $_->{item} } @items ) + : (); # Convert to a hash for quick searching my %hiddenitems = map { $_ => 1 } @hiddenitems; foreach my $itemnumber ( map { $_->{itemnumber} } @items ) { -- 2.4.6