From eacd25f29a596a60c6b954e750cab9fc47a28c1b Mon Sep 17 00:00:00 2001 From: Indranil Das Gupta Date: Fri, 3 Jul 2015 13:33:06 +0530 Subject: [PATCH] [PASSED QA] Bug 14487 - silence warns during checkin Test plan ========= 1/ check out an item and then check it back in. 1/ check the logs after the check-in to see the warns from returns.pl line 623 of : (a) Use of uninitialized value $holdingBranch (b) Use of uninitialized value $collectionBranch 2/ apply patch 3/ check out and check-in again. no warns are recorded this time. NOTE: Under Debian Jessie, there are other messages. Additionally, this only corrects the line 623 ones. Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall --- circ/returns.pl | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/circ/returns.pl b/circ/returns.pl index c36318f..91a6857 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -620,6 +620,8 @@ $template->param( $itemnumber = GetItemnumberFromBarcode( $query->param('barcode') ); if ( $itemnumber ) { my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber ); + $holdingBranch //= ''; + $collectionBranch //= ''; if ( ! ( $holdingBranch eq $collectionBranch ) ) { $template->param( collectionItemNeedsTransferred => 1, -- 1.7.2.5