From 635b8fc53a72a923612df9c018e5ccf0dc6032e8 Mon Sep 17 00:00:00 2001 From: Aleisha Date: Mon, 3 Aug 2015 23:44:03 +0000 Subject: [PATCH] Bug 14641: Warns in subscription-add.pl I think the warns are being triggered because there are brackets around it (like my ($selected_lettercode) ) which doesn't seem necessary as we're only declaring one variable? So I've removed the brackets. To test: 1) Reproduce warns by clicking New Subscription 2) Apply patch 3) Click New Subscription again 4) Confirm warns are gone --- serials/subscription-add.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl index ce6f91d..7d50f14 100755 --- a/serials/subscription-add.pl +++ b/serials/subscription-add.pl @@ -225,7 +225,7 @@ if ($op eq 'addsubscription') { } sub get_letter_loop { - my ($selected_lettercode) = @_; + my $selected_lettercode = @_; my $letters = GetLetters({ module => 'serial' }); return [ map { -- 1.7.10.4