Bugzilla – Attachment 4142 Details for
Bug 6351
Cannot delete library-specific circulation rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-Bug-6351-Unable-to-delete-branch-specific-circulatio.patch (text/plain), 1.03 KB, created by
D Ruth Holloway
on 2011-05-17 11:49:37 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
D Ruth Holloway
Created:
2011-05-17 11:49:37 UTC
Size:
1.03 KB
patch
obsolete
>From d30629e5807c5366abef3720c31f3bdfe7602eed Mon Sep 17 00:00:00 2001 >From: D Ruth Bavousett <ruth@bywatersolutions.com> >Date: Tue, 17 May 2011 11:45:48 -0400 >Subject: [PATCH] Bug 6351: Unable to delete branch-specific circulation rule > >The URL on the page did not have a branchcode, so the delete failed silently, and >returned the user to the "All" rules page. Turns out, the array for the rules was >not being populated with the branchcode! >--- > admin/smart-rules.pl | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > >diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl >index 3c77f93..5ba92d8 100755 >--- a/admin/smart-rules.pl >+++ b/admin/smart-rules.pl >@@ -376,6 +376,7 @@ my $sth2 = $dbh->prepare(" > $sth2->execute($branch); > > while (my $row = $sth2->fetchrow_hashref) { >+ $row->{'current_branch'} ||= $row->{'branchcode'}; > $row->{'humanitemtype'} ||= $row->{'itemtype'}; > $row->{'default_humanitemtype'} = 1 if $row->{'humanitemtype'} eq '*'; > $row->{'humancategorycode'} ||= $row->{'categorycode'}; >-- >1.7.2.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6351
:
4142
|
4148
|
5228
|
5229