Bugzilla – Attachment 41458 Details for
Bug 14661
space needed in added to staff side cart message, if items added are already in cart
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14661 - space needed in added to staff side cart message, if items added are already in cart
Bug-14661---space-needed-in-added-to-staff-side-ca.patch (text/plain), 1.80 KB, created by
Joonas Kylmälä
on 2015-08-12 11:18:36 UTC
(
hide
)
Description:
Bug 14661 - space needed in added to staff side cart message, if items added are already in cart
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2015-08-12 11:18:36 UTC
Size:
1.80 KB
patch
obsolete
>From 4cc56dd6e4943cf26e96e413b586322cbc5a7ea8 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 7 Aug 2015 08:39:19 -0700 >Subject: [PATCH] Bug 14661 - space needed in added to staff side cart message, > if items added are already in cart >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. > >Test: > >1. Search for records in your system. >2. In search results, select the first two records and choose Add to Cart. >3. Message returned, "2 item(s) added to your cart", as expected. >4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. >5. Message returned, "2 item(s) added to your cart2 already in your cart". >6. Apply this patch >7. Repeat steps 1 through 4 >8. Note the two phrases are on separate lines > >Signed-off-by: Heather Braum <hbraum@nekls.org> >Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/js/basket.js | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/basket.js b/koha-tmpl/intranet-tmpl/prog/en/js/basket.js >index 4086385..1c9e0a1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/basket.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/basket.js >@@ -185,6 +185,7 @@ function addSelRecords(valSel) { // function for adding a selection of biblios t > if (nbAdd) { > if (i > nbAdd) { > msg = MSG_NRECORDS_ADDED.format(nbAdd); >+ msg += "<br/>"; > msg += MSG_NRECORDS_IN_BASKET.format((i-nbAdd)); > } > else { >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14661
:
41431
|
41432
|
41433
|
41434
|
41458
|
41648