Bugzilla – Attachment 41604 Details for
Bug 14574
Correcting messages on intranet error pages so they make more sense
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14574: Fixing error messages on staff client so they make more sense
Bug-14574-Fixing-error-messages-on-staff-client-so.patch (text/plain), 4.78 KB, created by
Jonathan Druart
on 2015-08-18 14:46:55 UTC
(
hide
)
Description:
Bug 14574: Fixing error messages on staff client so they make more sense
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-08-18 14:46:55 UTC
Size:
4.78 KB
patch
obsolete
>From 0b4a649f976ac409b3b92b495b1be416bebe6e7e Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Tue, 21 Jul 2015 00:29:52 +0000 >Subject: [PATCH] Bug 14574: Fixing error messages on staff client so they make > more sense > >To test: >1) Go to cgi-bin/koha/errors/errornumber.pl to see the error messages which currently don't make sense (ie cgi-bin/koha/errors/401.pl etc). Have only made changes to 401, 403 and 404 >2) Apply patch >3) Go to cgi-bin/koha/errors/401.pl --> Check that it now says "This error means that you aren't authorized to view this page." and "Please log in and try again.". Check that 'log in' redirects to the log in page (mainpage.pl). >4) Go to cgi-bin/koha/errors/403.pl --> Check that it now says "This error means that you are forbidden to view this page." >5) Go to cgi-bin/koha/errors/404.pl --> This page should be very different. Check that the 'Error 404' is now in italics and not bold. Check that the page gives a list of reasons the user may have been given this error and some options for their next step. > >Signed-off-by: Catherine <cnorthcott.work@gmail.com> >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Amended patch: replace tab with 4 spaces. >Note: I am not sure the em tag is useful here. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/errors/401.tt | 3 ++- > koha-tmpl/intranet-tmpl/prog/en/modules/errors/403.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/errors/404.tt | 17 ++++++++++++----- > 3 files changed, 15 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/401.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/401.tt >index aa421d7..5c0d3cf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/401.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/401.tt >@@ -17,7 +17,8 @@ > <h1>An error has occurred!</h1> > <h2>Error 401</h2> > <ul style="margin-bottom: 1em; padding-bottom: 1em; border-bottom: 1px solid #CCC;"> >- <li>This error means that you aren't authorized to view this page</li> >+ <li>This error means that you aren't authorized to view this page.</li> >+ <li>Please <a href="/cgi-bin/koha/mainpage.pl">log in</a> and try again. > <li>To report this error, you can <a href="mailto:[% admin %]">email the Koha administrator</a>.</li> > <li>Use top menu bar to navigate to another part of Koha.</li> > </ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/403.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/403.tt >index 66dc92d..6ed5c3a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/403.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/403.tt >@@ -17,7 +17,7 @@ > <h1>An error has occurred!</h1> > <h2>Error 403</h2> > <ul style="margin-bottom: 1em; padding-bottom: 1em; border-bottom: 1px solid #CCC;"> >- <li>This error means that the link was broken and that the page doesn't exist</li> >+ <li>This error means that you are forbidden to view this page.</li> > <li>To report this error, you can <a href="mailto:[% admin %]">email the Koha administrator</a>.</li> > <li>Use top menu bar to navigate to another part of Koha.</li> > </ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/404.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/404.tt >index d461462..422aba3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/404.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/404.tt >@@ -15,11 +15,18 @@ > <div id="yui-main"> > <div class="yui-b"><div class="yui-g"> > <h1>An error has occurred!</h1> >- <h2>Error 404</h2> >- <ul style="margin-bottom: 1em; padding-bottom: 1em; border-bottom: 1px solid #CCC;"> >- <li>This error means that the link was broken and that the page doesn't exist</li> >- <li>To report this error, you can <a href="mailto:[% admin %]">email the Koha administrator</a>.</li> >- <li>Use top menu bar to navigate to another part of Koha.</li> >+ <h3><em>Error 404</em></h3> >+ <h3>This message may have been caused by any of the following reasons:</h3> >+ <ul style="padding-bottom: 0.5em;"> >+ <li>You made use of an external link to an item that is no longer available</li> >+ <li>You followed an outdated link e.g. from a search engine or a bookmark</li> >+ <li>You tried to access a page that needs authentification</li> >+ <li>An internal link in the client is broken and the page does not exist</li> >+ </ul> >+ <h3>What's next?</h3> >+ <ul style="margin-bottom: 1em; padding-bottom: 1em; border-bottom: 1px solid #CCC;"> >+ <li>Use top menu bar to navigate to another part of Koha.</li> >+ <li>To report a broken link or any other issue, please send an <a href="mailto:[% admin %]">email to the Koha Administrator</a></li> > </ul> > </div> > >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14574
:
41105
|
41522
| 41604