From b623f198febf58222fba1d89fa88188aed66ad2f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 18 Aug 2015 18:15:02 +0100 Subject: [PATCH] Bug 14655: Add a warning on the about page if patrons have requested privacy New warning on the about page if at least a patron has requested a privacy on checkin but the AnonymousPatron is not set to a valid patron. --- about.pl | 5 +++++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 +++ 2 files changed, 8 insertions(+) diff --git a/about.pl b/about.pl index 29777cf..dbed815 100755 --- a/about.pl +++ b/about.pl @@ -34,6 +34,7 @@ use C4::Context; use C4::Installer; use Koha; +use Koha::Borrowers; use Koha::Config::SysPrefs; #use Smart::Comments '####'; @@ -77,6 +78,9 @@ my $warnPrefAnonymousPatron = ( and not C4::Context->preference('AnonymousPatron') ); +my $anonymous_patron = Koha::Borrowers->find( C4::Context->preference('AnonymousPatron') ); +my $warnPrefAnonymousPatron_PatronDoesNotExist = ( not $anonymous_patron and Koha::Borrowers->search({ privacy => 2 })->count ); + my $errZebraConnection = C4::Context->Zconn("biblioserver",0)->errcode(); my $warnIsRootUser = (! $loggedinuser); @@ -227,6 +231,7 @@ $template->param( warnPrefBiblioAddsAuthorities => $warnPrefBiblioAddsAuthorities, warnPrefEasyAnalyticalRecords => $warnPrefEasyAnalyticalRecords, warnPrefAnonymousPatron => $warnPrefAnonymousPatron, + warnPrefAnonymousPatron_PatronDoesNotExist => $warnPrefAnonymousPatron_PatronDoesNotExist, errZebraConnection => $errZebraConnection, warnIsRootUser => $warnIsRootUser, warnNoActiveCurrency => $warnNoActiveCurrency, diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt index 4a06fe4..f178ab7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt @@ -122,6 +122,9 @@ [% IF warnPrefAnonymousPatron %] Warning System preference 'OPACPrivacy' set, but AnonymousPatron preference is set to '0'. Set it to a valid borrower number if you want that this feature works correctly. [% END %] + [% IF warnPrefAnonymousPatron_PatronDoesNotExist %] + Warning Some patrons have requested a privacy on returning item but the AnonymousPatron pref is not set correctly. Set it to a valid borrower number if you want that this feature works correctly. + [% END %] [% IF warnNoActiveCurrency %] Warning No active currency is defined. Please go to Administration > Currencies and exchange rates and mark one currency as active. [% END %] -- 2.1.0