Bugzilla – Attachment 41644 Details for
Bug 14691
Can't delete patron with ' character in cardnumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14691 - Can't delete patron with ' character in cardnumber
Bug-14691---Cant-delete-patron-with--character-in-.patch (text/plain), 1.92 KB, created by
Liz Rea
on 2015-08-19 01:31:07 UTC
(
hide
)
Description:
Bug 14691 - Can't delete patron with ' character in cardnumber
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2015-08-19 01:31:07 UTC
Size:
1.92 KB
patch
obsolete
>From 3e0e7f75458af29b155308bb5604c9b20740c052 Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Wed, 19 Aug 2015 13:29:48 +1200 >Subject: [PATCH] Bug 14691 - Can't delete patron with ' character in > cardnumber > >Test plan: > >1. Create patron account with cardnumber sss'ssssssss and save the account. >2. Try to delete the account. Nothing happens. >3. Apply the patch, refresh the page. >4. Try to delete the account; note the Delete pop-up message that now appears. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >index 70edbc0..a6b8486 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >@@ -107,7 +107,7 @@ function update_child() { > function confirm_reregistration() { > var is_confirmed = window.confirm(_("Are you sure you want to renew this patron's registration?")); > if (is_confirmed) { >- window.location = '/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% borrowernumber %]&cardnumber=[% cardnumber %]&desintation=[% destination %]&reregistration=y'; >+ window.location = '/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% borrowernumber %]&cardnumber=[% cardnumber | replace( "'", "\\'" ) %]&desintation=[% destination %]&reregistration=y'; > } > } > function export_barcodes() { >@@ -118,7 +118,7 @@ function printx_window(print_type) { > var handler = print_type.match(slip_re) ? "printslip" : "summary-print"; > window.open("/cgi-bin/koha/members/" + handler + ".pl?borrowernumber=[% borrowernumber %]&print=" + print_type, "printwindow"); > return false; >-} >+}i > function searchToHold(){ > var date = new Date(); > date.setTime(date.getTime() + (10 * 60 * 1000)); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14691
:
41644
|
41645
|
41803
|
42897