Bugzilla – Attachment 41657 Details for
Bug 14644
SIP2 terminal authentication via telnet transport broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14644: unbreak SIP2 terminal login when using telnet transport
Bug-14644-unbreak-SIP2-terminal-login-when-using-t.patch (text/plain), 2.08 KB, created by
Jonathan Druart
on 2015-08-19 10:56:17 UTC
(
hide
)
Description:
Bug 14644: unbreak SIP2 terminal login when using telnet transport
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-08-19 10:56:17 UTC
Size:
2.08 KB
patch
obsolete
>From 5e070722a2e1414bcebf9a29c9bb9918df30d2e5 Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Tue, 4 Aug 2015 15:59:39 +0000 >Subject: [PATCH] Bug 14644: unbreak SIP2 terminal login when using telnet > transport > >This patch fixes breakage introduced by the patch for bug 13506 >that prevented SIP2 clients from authenticating themselves over >the telnet transport. Attempts to do so would manifest by the >SIPServer backend crashing and the connection getting closed. > >To test: > >[1] Use the stock SIPServer config, etc/SIPconfig.xml, and ensure > that the database contains a staff user whose username is 'term1' > and password is 'term1' that has the circulate permission. >[2] Start SIPServer, telnet to port 8023, and attempt to log in. The > connection will be aborted: > > $ telnet localhost 8023 > Trying 127.0.0.1... > Connected to localhost. > Escape character is '^]'. > login: term1 > password: term1 > Connection closed by foreign host. > >[3] Apply the patch and restart SIPSever, then repeat step 2. This time, > the login should succeed: > > $ telnet localhost 8023 > Trying 127.0.0.1... > Connected to localhost. > Escape character is '^]'. > login: term1 > password: term1 > Login OK. Initiating SIP > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/SIP/SIPServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/SIPServer.pm b/C4/SIP/SIPServer.pm >index 20a97c6..8722ab6 100755 >--- a/C4/SIP/SIPServer.pm >+++ b/C4/SIP/SIPServer.pm >@@ -205,7 +205,7 @@ sub telnet_transport { > syslog("LOG_DEBUG", "telnet_transport 2: uid length %s, pwd length %s", length($uid), length($pwd)); > > if (exists ($config->{accounts}->{$uid}) >- && ($pwd eq $config->{accounts}->{$uid}->password())) { >+ && ($pwd eq $config->{accounts}->{$uid}->{password})) { > $account = $config->{accounts}->{$uid}; > if ( C4::SIP::Sip::MsgType::login_core($self,$uid,$pwd) ) { > last; >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14644
:
41359
|
41373
| 41657