From 906bd115ef757504334c0e3a89ddcdd67adfea13 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 21 Aug 2015 10:47:19 +0200 Subject: [PATCH] Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart --- opac/opac-reserve.pl | 7 ------- 1 file changed, 7 deletions(-) diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl index 6e6e928..4dff9a2 100755 --- a/opac/opac-reserve.pl +++ b/opac/opac-reserve.pl @@ -410,13 +410,6 @@ foreach my $biblioNum (@biblionumbers) { } foreach my $itemInfo (@{$biblioData->{itemInfos}}) { - $debug and warn $itemInfo->{'notforloan'}; - - # Get reserve fee. - my $fee = GetReserveFee(undef, $borrowernumber, $itemInfo->{'biblionumber'}, 'a', - ( $itemInfo->{'biblioitemnumber'} ) ); - $itemInfo->{'reservefee'} = sprintf "%.02f", ($fee ? $fee : 0.0); - if ($itemLevelTypes && $itemInfo->{itype}) { $itemInfo->{description} = $itemTypes->{$itemInfo->{itype}}{description}; $itemInfo->{imageurl} = getitemtypeimagesrc() . "/". $itemTypes->{$itemInfo->{itype}}{imageurl}; -- 2.1.0