Bugzilla – Attachment 4248 Details for
Bug 5917
Switch Koha to use Template::Toolkit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Additional fixes
0001-Follow-up-fixes-for-Bug-5917-Switch-Koha-to-use-Temp.patch (text/plain), 5.56 KB, created by
Owen Leonard
on 2011-05-24 19:33:12 UTC
(
hide
)
Description:
Additional fixes
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-05-24 19:33:12 UTC
Size:
5.56 KB
patch
obsolete
>From 986927c510051e3072a91eab2f9e9e00f0272ae3 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 24 May 2011 15:26:20 -0400 >Subject: [PATCH] Follow-up fixes for Bug 5917, Switch Koha to use Template::Toolkit >Content-Type: text/plain; charset="utf-8" > >While fixing Bug 6395 I found a few other instances of leftover >TMPL usage. >--- > .../en/modules/admin/branch_transfer_limits.tt | 3 +-- > .../prog/en/modules/catalogue/issuehistory.tt | 3 +-- > .../en/modules/reports/guided_reports_start.tt | 13 +++---------- > .../prog/en/modules/serials/serials-recieve.tt | 3 +-- > 4 files changed, 6 insertions(+), 16 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt >index 9410c23..b839529 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt >@@ -127,8 +127,7 @@ > > <tbody> > [% FOREACH to_branch_loo IN codes_loo.to_branch_loop %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight"><!-- TMPL_ELSE >---><tr>[% END %] >+ [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] > <td><label style="min-width:400px;" for="[% to_branch_loo.code %][% to_branch_loo.toBranch %]row">[% to_branch_loo.toBranch %] - [% to_branch_loo.toBranchname %]</label></td> > <td><input type="checkbox" id="[% to_branch_loo.code %][% to_branch_loo.toBranch %]row" name="[% to_branch_loo.code %]_[% to_branch_loo.toBranch %]" [% IF ( to_branch_loo.isChecked ) %]checked="checked" [% END %] /></td> > </tr> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >index d4443f0..bc2490f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >@@ -33,8 +33,7 @@ > </tr></thead> > <tbody> > [% FOREACH issue IN issues %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight"><!-- TMPL_ELSE >---><tr>[% END %] >+ [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] > <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% issue.borrowernumber %]">[% issue.surname %][% IF ( issue.firstname ) %], [% issue.firstname %][% END %]</a></td> > <td>[% IF ( issue.barcode ) %] > <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% issue.biblionumber %]&itemnumber=[% issue.itemnumber %]">[% issue.barcode %]</a> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 24c5a13..5491ede 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -392,8 +392,7 @@ canned reports and writing custom SQL reports.</p> > [% IF ( definitions ) %] > <fieldset><legend>Dictionary Definitions</legend><table> > [% FOREACH definition IN definitions %] >- <tr><td><input type="checkbox" name="definition" value="<!-- >-TMPL_VAR NAME="id" -->" /> [% definition.name %]</td></tr> >+ <tr><td><input type="checkbox" name="definition" value="[% definition.id %]" /> [% definition.name %]</td></tr> > [% END %] > </table> > [% END %] >@@ -415,10 +414,7 @@ TMPL_VAR NAME="id" -->" /> [% definition.name %]</td></tr> > <input type="hidden" name="criteria" value="[% criteriastring %]" /> > <fieldset><table> > [% FOREACH total_b IN total_by %] >-<tr><td><input type="checkbox" name="total_by" id="<!-- TMPL_VAR >-NAME="name" -->" value="<!-- TMPL_VAR >-NAME="name" -->" /> <label for="<!-- TMPL_VAR >-NAME="name" -->">[% total_b.name %]</label></td> >+<tr><td><input type="checkbox" name="total_by" id="[% total_b.name %]" value="[% total_b.name %]" /> <label for="[% total_b.name %]">[% total_b.name %]</label></td> > <td><select name="[% total_b.name %]_tvalue"> > > [% FOREACH selec IN total_b.select %] >@@ -447,10 +443,7 @@ NAME="name" -->">[% total_b.name %]</label></td> > <input type="hidden" name="definition" value="[% definition %]" /> > <input type="hidden" name="totals" value="[% totals %]" /> > <fieldset><table>[% FOREACH order_b IN order_by %] >-<tr><td><input type="checkbox" id="<!-- TMPL_VAR >-NAME="name" -->" name="order_by" value="<!-- TMPL_VAR >-NAME="name" -->" /> <label for="<!-- TMPL_VAR >-NAME="name" -->">[% order_b.name %]</label></td><td> >+<tr><td><input type="checkbox" id="[% order_b.name %]" name="order_by" value="[% order_b.name %]" /> <label for="[% order_b.name %]">[% order_b.name %]</label></td><td> > <select name="[% order_b.name %]_ovalue"> > > [% FOREACH selec IN order_b.select %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt >index 33f267a..f45ffeb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt >@@ -4,8 +4,7 @@ > <script language="JavaScript" type="text/javascript"> > //<![CDATA[ > function popup() { >- window.open("subscription-renew.pl?subscriptionid=<!-- TMPL_VAR >-name="subscriptionid">","subscription_renewal",'width=700,height=400,toolbar=false,scrollbars=yes'); >+ window.open("subscription-renew.pl?subscriptionid=[% subscriptionid %]","subscription_renewal",'width=700,height=400,toolbar=false,scrollbars=yes'); > } > > function barcode_check(){ >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5917
:
3505
|
3850
|
3851
|
3852
|
4248
|
4375