From e42125e6c5df2f938aec691f248cb6ee3b1a93ce Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 2 Sep 2015 14:28:52 +0100 Subject: [PATCH] [PASSED QA] Bug 7634: Prevent permanent_location to be set to NULL if not defined The permanent_location is correctly filled when an item is added from the cataloguing module (routine set_item_default_location from cataloguing/additem.pl). But when records are imported, this filled is not managed. It's only on editing (_do_column_fixes_for_mod called from ModItem). This patch set the permanent_location item fields to the location value for all items created, even the imported ones. Test plan: 0/ Do not apply this patch 1/ Import a record with items using the "Stage MARC for import" tool 2/ Check the values for the permanent_location in the items table. They are set to NULL 3/ Apply this patch 4/ Repeat 2 and confirm that now the permanent_location values are set to the location values. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer --- C4/Items.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/Items.pm b/C4/Items.pm index 0e639dc..1c6d7ef 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -2144,6 +2144,7 @@ sub _koha_new_item { my ( $item, $barcode ) = @_; my $dbh=C4::Context->dbh; my $error; + $item->{permanent_location} //= $item->{location}; my $query = "INSERT INTO items SET biblionumber = ?, -- 1.9.1