Bugzilla – Attachment 42796 Details for
Bug 12311
Batch modification of checked out and lost items checks them in
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 12311: Do not return a lost item if modified in a batch
SIGNED-OFFBug-12311-Do-not-return-a-lost-item-if-m.patch (text/plain), 1.94 KB, created by
Héctor Eduardo Castro Avalos
on 2015-09-22 17:09:30 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 12311: Do not return a lost item if modified in a batch
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2015-09-22 17:09:30 UTC
Size:
1.94 KB
patch
obsolete
>From c3a9e2f3c885e7e5360969a50c84721a73f3d8f2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Sep 2015 11:44:32 +0100 >Subject: [PATCH] [SIGNED-OFF]Bug 12311: Do not return a lost item if modified > in a batch >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >If a item is lost and issued, and you modify it in a batch, the item >will be marked as returned. It should only be returned if the item is >marked as lost. > >Test plan: >1/ Check an item out and mark it as lost >2/ Edit it in a batch (tools/batchMod.pl) and edit a field (notes for >instance) >3/ The item should still be issued to the patron >4/ Edit it in a batch and edit the lost value, marked it as not lost >5/ The item should still be issued to the patron >6/ Edit it in a batch and edit the lost value, marked it as lost >7/ The item should have been returned. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised. Just one comment, lost status can be changed only if you change default framework to another framework then edit the item. If you change it in Item menu at left side of screen this will remove the item from patronâs checkouts and patron charged for lost item. >--- > tools/batchMod.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 4ed0f10..5108419 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -198,7 +198,7 @@ if ($op eq "action") { > if ( $modified ) { > eval { > if ( my $item = ModItemFromMarc( $localmarcitem, $itemdata->{biblionumber}, $itemnumber ) ) { >- LostItem($itemnumber, 'MARK RETURNED') if $item->{itemlost}; >+ LostItem($itemnumber, 'MARK RETURNED') if $item->{itemlost} and not $itemdata->{itemlost}; > } > }; > } >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12311
:
42554
|
42796
|
42961