From 28361b2c87dd2b115251a233b6f33985b6418c15 Mon Sep 17 00:00:00 2001 From: remi Date: Wed, 20 May 2015 13:26:23 -0400 Subject: [PATCH] [PASSED QA] Bug 14518 - Allow deleting records with holds (and no item) after confirmation Cleaning up records with no item but holds is impossible since the code does not consider the result from the confirmation popup. This situation happens to our client in their (annual) cleanup. I. Setup Create the following if needed: 1) A patron for placing holds and checkouts 2) A test bibliographic record 3) An item for the record. Set the barcode to "DELETEME" II. Corrupting the Database 1) Checkout the item "DELETEME" 2) Place a record level hold on the test record (next available item) 3) Checkin the item "DELETEME" 4) MySQL: DELETE FROM items WHERE barcode="DELETEME"; III. Deleting the record. 1) On the test record's details page: Edit -> Delete record 2) Click 'yes' in the prompt 3) Nothing happens. IV. Fixing the bug 1) Apply the patch 2) Repeat step III to delete the record 3) Record is deleted Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Note: It's not possible in Koha to place a hold on a record with items, so the effect described here is more likely to be the result of a migration issue or another bug. But doesn't hurt to provide a way out :) --- koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc index ee39f31..8f44496 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc @@ -57,11 +57,7 @@ is_confirmed = confirm(_("Are you sure you want to delete this record?")); } if (is_confirmed) { - if ( count > 0 || holdcount > 0 ){ - return false; - } else { window.location="/cgi-bin/koha/cataloguing/addbiblio.pl?op=delete&biblionumber=[% biblionumber %]"; - } } else { return false; } -- 1.9.1