Bugzilla – Attachment 43159 Details for
Bug 14607
Make Baker & Taylor cover images accessible by UPC as well as ISBN
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC
Bug-14607-QA-followup-Fix-one-missing-occurence-in.patch (text/plain), 4.98 KB, created by
Jonathan Druart
on 2015-10-06 11:14:31 UTC
(
hide
)
Description:
Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-10-06 11:14:31 UTC
Size:
4.98 KB
patch
obsolete
>From fcac3165ffb232ca4b46a52b069bce2e815421c3 Mon Sep 17 00:00:00 2001 >From: Jesse Weaver <pianohacker@gmail.com> >Date: Mon, 14 Sep 2015 16:22:12 -0600 >Subject: [PATCH] Bug 14607: (QA followup) Fix one missing occurence, incorrect > calls to GetNormalizedUPC > >Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 9 +++++---- > opac/opac-readingrecord.pl | 2 +- > opac/opac-user.pl | 4 +++- > 3 files changed, 9 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index b7f443b..f755035 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -170,7 +170,7 @@ > [% IF ( bt_id ) %] > <a href="https://[% BakerTaylorBookstoreURL |html %][% bt_id %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /></a> > [% ELSE %] >- <span class="no-image">No cover image available</span><!-- BakerTaylor needs normalized_isbn! --> >+ <span class="no-image">No cover image available</span><!-- BakerTaylor needs normalized_upc or normalized_isbn! --> > [% END %] > [% END %] > >@@ -410,10 +410,11 @@ > [% END %] > > [% IF ( BakerTaylorEnabled ) %] >- [% IF ( OVERDUE.normalized_isbn ) %] >- <a href="https://[% BakerTaylorBookstoreURL |html %][% OVERDUE.normalized_isbn %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% OVERDUE.normalized_isbn %]" /></a> >+ [% bt_id = ( OVERDUE.normalized_upc || OVERDUE.normalized_isbn ) %] >+ [% IF ( bt_id ) %] >+ <a href="https://[% BakerTaylorBookstoreURL |html %][% bt_id %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /></a> > [% ELSE %] >- <!-- BakerTaylor needs normalized_isbn! --><span class="no-image">No cover image available</span> >+ <span class="no-image">No cover image available</span><!-- BakerTaylor needs normalized_upc or normalized_isbn! --> > [% END %] > [% END %] > >diff --git a/opac/opac-readingrecord.pl b/opac/opac-readingrecord.pl >index d2fcd47..df03b30 100755 >--- a/opac/opac-readingrecord.pl >+++ b/opac/opac-readingrecord.pl >@@ -97,7 +97,7 @@ foreach my $issue ( @{$issues} ) { > C4::Context->preference('marcflavour') ); > $issue->{subtitle} = > GetRecordValue( 'subtitle', $marc_rec, $issue->{frameworkcode} ); >- $issue->{normalized_upc} = GetNormalizedUPC( $marc_rec, $issue->{frameworkcode} ); >+ $issue->{normalized_upc} = GetNormalizedUPC( $marc_rec, C4::Context->preference('marcflavour') ); > } > # My Summary HTML > if ($opac_summary_html) { >diff --git a/opac/opac-user.pl b/opac/opac-user.pl >index c6935de..62b7dce 100755 >--- a/opac/opac-user.pl >+++ b/opac/opac-user.pl >@@ -185,7 +185,8 @@ if ($issues){ > } > } > $issue->{'charges'} = $charges; >- $issue->{'subtitle'} = GetRecordValue('subtitle', GetMarcBiblio($issue->{'biblionumber'}), GetFrameworkCode($issue->{'biblionumber'})); >+ my $marcrecord = GetMarcBiblio( $issue->{'biblionumber'} ); >+ $issue->{'subtitle'} = GetRecordValue('subtitle', $marcrecord, GetFrameworkCode($issue->{'biblionumber'})); > # check if item is renewable > my ($status,$renewerror) = CanBookBeRenewed( $borrowernumber, $issue->{'itemnumber'} ); > ($issue->{'renewcount'},$issue->{'renewsallowed'},$issue->{'renewsleft'}) = GetRenewCount($borrowernumber, $issue->{'itemnumber'}); >@@ -231,6 +232,7 @@ if ($issues){ > > my $isbn = GetNormalizedISBN($issue->{'isbn'}); > $issue->{normalized_isbn} = $isbn; >+ $issue->{normalized_upc} = GetNormalizedUPC( $marcrecord, C4::Context->preference('marcflavour') ); > > # My Summary HTML > if (my $my_summary_html = C4::Context->preference('OPACMySummaryHTML')){ >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14607
:
41393
|
41633
|
42253
|
42547
|
43018
|
43019
|
43157
|
43158
| 43159