Bugzilla – Attachment 43243 Details for
Bug 14544
Move the list related code to Koha::Virtualshelves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14544 - Handle database error when creating a shelf with DB admin account
Bug-14544---Handle-database-error-when-creating-a-.patch (text/plain), 2.51 KB, created by
Jonathan Druart
on 2015-10-08 09:11:25 UTC
(
hide
)
Description:
Bug 14544 - Handle database error when creating a shelf with DB admin account
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-10-08 09:11:25 UTC
Size:
2.51 KB
patch
obsolete
>From 0be86e67474f3eca7bded9169c0be9690937867c Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Wed, 2 Sep 2015 10:04:04 +0200 >Subject: [PATCH] Bug 14544 - Handle database error when creating a shelf with > DB admin account > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >I don't think this is useful, it will be a mess if we have to check this >case everywhere. But it works! >I let the cut to the QAer or RM. >--- > Koha/Exceptions.pm | 4 ++++ > Koha/Virtualshelf.pm | 4 ++++ > koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 2 ++ > 3 files changed, 10 insertions(+) > >diff --git a/Koha/Exceptions.pm b/Koha/Exceptions.pm >index f6534e0..4409296 100644 >--- a/Koha/Exceptions.pm >+++ b/Koha/Exceptions.pm >@@ -28,6 +28,10 @@ use Exception::Class ( > 'Koha::Exceptions::Virtualshelves::ShareHasExpired' => { > isa => 'Koha::Exceptions::Exception', > description=> 'Cannot share this shelf, the share has expired', >+ }, >+ 'Koha::Exceptions::Virtualshelves::UseDbAdminAccount' => { >+ isa => 'Koha::Exceptions::Exception', >+ description => "Invalid use of database administrator account", > } > ); > >diff --git a/Koha/Virtualshelf.pm b/Koha/Virtualshelf.pm >index d80f249..7ce2738 100644 >--- a/Koha/Virtualshelf.pm >+++ b/Koha/Virtualshelf.pm >@@ -51,6 +51,10 @@ our $PUBLIC = 2; > sub store { > my ( $self ) = @_; > >+ unless ( $self->owner ) { >+ Koha::Exceptions::Virtualshelves::UseDbAdminAccount->throw; >+ } >+ > unless ( $self->is_shelfname_valid ) { > Koha::Exceptions::Virtualshelves::DuplicateObject->throw; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index 44a2dae..546f4fa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -351,6 +351,8 @@ function placeHold () { > No biblio has been removed. > [% CASE 'Koha::Exceptions::Virtualshelves::DuplicateObject' %] > An error occurred when inserting this list. The name already [% shelfname %] exists. >+ [% CASE 'Koha::Exceptions::Virtualshelves::UseDbAdminAccount' %] >+ List could not be created. (Do not use the database administrator account.). > [% CASE 'DBIx::Class::Exception' %] > [% m.msg %] > [% CASE %] >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14544
:
41034
|
41035
|
41036
|
41037
|
41038
|
41039
|
41040
|
41041
|
41042
|
41403
|
41404
|
41405
|
41406
|
41407
|
41408
|
41409
|
41410
|
41411
|
41412
|
41584
|
41585
|
41586
|
41587
|
41588
|
41589
|
41590
|
41591
|
41592
|
41593
|
41594
|
41595
|
41596
|
41597
|
41598
|
41599
|
41600
|
41601
|
41716
|
41717
|
41718
|
41719
|
41720
|
41721
|
41722
|
41723
|
41724
|
41725
|
41726
|
41727
|
41728
|
41729
|
41730
|
41731
|
41732
|
41733
|
41766
|
41909
|
41910
|
41913
|
41914
|
41915
|
41917
|
41918
|
41919
|
41924
|
41927
|
41931
|
41932
|
41953
|
41954
|
41955
|
41956
|
41957
|
41958
|
41959
|
41960
|
41961
|
41962
|
41963
|
41964
|
41965
|
41966
|
41967
|
41968
|
41969
|
41970
|
41973
|
41974
|
41975
|
41976
|
41977
|
41978
|
41979
|
41980
|
41981
|
41982
|
41983
|
41986
|
41988
|
42192
|
42199
|
42200
|
42201
|
42202
|
42203
|
42204
|
42205
|
42206
|
42207
|
42208
|
42209
|
42210
|
42211
|
42212
|
42213
|
42214
|
42215
|
42216
|
42217
|
42218
|
42219
|
42638
|
43223
|
43224
|
43225
|
43226
|
43227
|
43228
|
43229
|
43230
|
43231
|
43232
|
43233
|
43234
|
43235
|
43236
|
43237
|
43238
|
43239
|
43240
|
43241
|
43242
|
43243
|
43296
|
43334
|
43335
|
43403
|
43456
|
43457
|
43458
|
43459
|
43460
|
43461
|
43462
|
43463
|
43464
|
43465
|
43466
|
43467
|
43469
|
43470
|
43471
|
43472
|
43473
|
43474
|
43475
|
43476
|
43477
|
43478
|
43479
|
43480
|
43481
|
43482
|
43485
|
43486
|
43487
|
44467
|
44468
|
44469
|
44470
|
44471
|
44472
|
44473
|
44474
|
44475
|
44476
|
44477
|
44478
|
44479
|
44480
|
44481
|
44482
|
44483
|
44484
|
44485
|
44486
|
44487
|
44758
|
44845
|
44852
|
44863
|
44872