Bugzilla – Attachment 43495 Details for
Bug 14244
viewing a bib item's circ history requires circulation permissions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14244: viewing a bib item's circ history requires circulation permissions
Bug-14244-viewing-a-bib-items-circ-history-require.patch (text/plain), 1.54 KB, created by
Jonathan Druart
on 2015-10-16 11:03:29 UTC
(
hide
)
Description:
Bug 14244: viewing a bib item's circ history requires circulation permissions
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-10-16 11:03:29 UTC
Size:
1.54 KB
patch
obsolete
>From 663aa74f0c2d758ff6968c87644aaee3738b6964 Mon Sep 17 00:00:00 2001 >From: Thomas Misilo <misilot@fit.edu> >Date: Wed, 16 Sep 2015 13:43:28 -0400 >Subject: [PATCH] Bug 14244: viewing a bib item's circ history requires > circulation permissions > >On issuehistory.pl you have: > > flagsrequired => { circulate => "circulate_remaining_permissions" }, > >But that really doesn't make sense. People should be able to view the history of circulation without having permission to circulate items themselves > >This patch changes the required permissions from circulate to catalogue. > >Test Plan: >1. Login as user without the circulate_remaining_permissions >2. Attempt to view Circulation History of an Item >3. Does not work >4. Apply Patch >5. Attempt to view circulation history with a user that has access to the staff side. >6. Can view circulation history now > >Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > catalogue/issuehistory.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/catalogue/issuehistory.pl b/catalogue/issuehistory.pl >index fae5038..b106143 100755 >--- a/catalogue/issuehistory.pl >+++ b/catalogue/issuehistory.pl >@@ -34,7 +34,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > query => $query, > type => "intranet", > authnotrequired => 0, >- flagsrequired => { circulate => "circulate_remaining_permissions" }, >+ flagsrequired => { catalogue => 1 }, > } > ); > >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14244
:
42622
|
43441
|
43495
|
47245
|
47257
|
47258
|
47694
|
47695