From 3bbcf1af216a3b9ed54273afa172596991dec182 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 23 Oct 2015 09:32:18 +0100 Subject: [PATCH] Bug 15052: Add diagnostic for the TestBuilder tests Sometimes t/db_dependent/TestBuilder.t fails with 'TestBuilder can create a entry for every sources' but we don't know which ones have failed. Test plan: Create the following file: Koha/Schema/Result/Test.pm package Koha::Schema::Result::Test; use base 'DBIx::Class::Core'; __PACKAGE__->table("test"); 1; If you don't have a table named 'test' in your DB, prove t/db_dependent/TestBuilder.t should return a failure, but without any explanation. With this patch you should get a diag and know what's wrong. --- t/db_dependent/TestBuilder.t | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/TestBuilder.t b/t/db_dependent/TestBuilder.t index bec4834..70aa7cd 100644 --- a/t/db_dependent/TestBuilder.t +++ b/t/db_dependent/TestBuilder.t @@ -30,12 +30,15 @@ my $builder = t::lib::TestBuilder->new(); is( $builder->build(), undef, 'build without arguments returns undef' ); my @sources = $builder->schema->sources; -my $nb_failure = 0; +my @source_in_failure; for my $source (@sources) { eval { $builder->build( { source => $source } ); }; - $nb_failure++ if ($@); + push @source_in_failure, $source if $@; +} +is( @source_in_failure, 0, 'TestBuilder should be able to create an object for every sources' ); +if ( @source_in_failure ) { + diag ("The following sources have not been generated correctly: " . join ', ', @source_in_failure) } -is( $nb_failure, 0, 'TestBuilder can create a entry for every sources' ); my $my_overduerules_transport_type = { message_transport_type => { -- 2.1.0