From 605c01b7459e0607fedf78a242b465757c9d3cbc Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 21 Oct 2015 14:08:05 +0100 Subject: [PATCH] [PASSED QA] Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Signed-off-by: Tomas Cohen Arazi Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. Also tried setting &batch=1 to force it to show the batch page, and it says I'm not allowed to do batch checkouts for that patron. Great! Signed-off-by: Kyle M Hall --- .../intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index 8c058f1..9137efb 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -65,7 +65,7 @@
    [% IF ( circview ) %]
  • [% ELSE %]
  • [% END %]Check out
  • [% IF Koha.Preference('BatchCheckouts') && - Koha.Preference('BatchCheckoutsValidCategories').split('\|').grep(categorycode).size > 0 %] + Koha.Preference('BatchCheckoutsValidCategories').split('\|').grep('^' _ categorycode _ '$').size > 0 %] [% IF ( batch_checkout_view ) %]
  • [% ELSE %]
  • [% END %]Batch check out
  • [% END %] [% IF ( CAN_user_borrowers ) %] -- 1.7.2.5