From 5d70ee305799b566ca12e8d452965356dea154bd Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 1 Jan 2015 18:48:03 -0500 Subject: [PATCH] [PASSED QA] Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter Signed-off-by: Katrin Fischer --- C4/Overdues.pm | 6 +++--- members/print_overdues.pl | 4 ++-- misc/cronjobs/overdue_notices.pl | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/C4/Overdues.pm b/C4/Overdues.pm index 330e6bd..0fc6232 100644 --- a/C4/Overdues.pm +++ b/C4/Overdues.pm @@ -57,7 +57,7 @@ BEGIN { &RemoveNotifyLine &AddNotifyLine &GetOverdueMessageTransportTypes - &parse_letter + &parse_overdues_letter ); # subs to remove @@ -955,7 +955,7 @@ sub GetOverdueMessageTransportTypes { return \@mtts; } -=head2 parse_letter +=head2 parse_overdues_letter parses the letter template, replacing the placeholders with data specific to this patron, biblio, or item for overdues @@ -971,7 +971,7 @@ substituted keys and values. =cut -sub parse_letter { +sub parse_overdues_letter { my $params = shift; foreach my $required (qw( letter_code borrowernumber )) { return unless ( exists $params->{$required} && $params->{$required} ); diff --git a/members/print_overdues.pl b/members/print_overdues.pl index 3cc204b..526f615 100755 --- a/members/print_overdues.pl +++ b/members/print_overdues.pl @@ -25,7 +25,7 @@ use C4::Context; use C4::Auth; use C4::Output; use C4::Members qw(GetOverdues); -use C4::Overdues qw(parse_letter); +use C4::Overdues qw(parse_overdues_letter); my $input = new CGI; @@ -47,7 +47,7 @@ my $branchcode = C4::Context->userenv->{'branch'}; my $overdues = GetOverdues($borrowernumber); -my $letter = parse_letter( +my $letter = parse_overdues_letter( { letter_code => 'OVERDUES_SLIP', borrowernumber => $borrowernumber, diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index b9c0767..2f9fa68 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -672,7 +672,7 @@ END_SQL my $print_sent = 0; # A print notice is not yet sent for this patron for my $mtt ( @message_transport_types ) { - my $letter = parse_letter( + my $letter = parse_overdues_letter( { letter_code => $overdue_rules->{"letter$i"}, borrowernumber => $borrowernumber, branchcode => $branchcode, -- 1.9.1