Attachment 43944 Details for Bug 14889 – Bug 14889: QA Follow-up

[patch] Bug 14889: QA Follow-up

Bug-14889-QA-Follow-up.patch (text/plain), 2.24 KB, created by Katrin Fischer on 2015-10-25 09:36:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-10-25 09:36:44 UTC

Size: 2.24 KB

patch

obsolete

>From 1ea22829f1293654df845c3d779f7525ae821f19 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Sun, 25 Oct 2015 10:33:50 +0100
>Subject: [PATCH] Bug 14889: QA Follow-up
>
>- Removes unused package from BiblioFramework.pm
>- Makes framework table sortable
>- Some small changes in wording of error messages
>---
> Koha/BiblioFramework.pm                                           | 2 --
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt | 6 +++---
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/Koha/BiblioFramework.pm b/Koha/BiblioFramework.pm
>index 39b1425..7ad542d 100644
>--- a/Koha/BiblioFramework.pm
>+++ b/Koha/BiblioFramework.pm
>@@ -19,8 +19,6 @@ use Modern::Perl;
> 
> use Carp;
> 
>-use C4::Members::Messaging;
>-
> use Koha::Database;
> 
> use base qw(Koha::Object);
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt
>index a0be0da..11d3edc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt
>@@ -20,7 +20,7 @@
>                 { "aTargets": [ -1, -2, -3, -4, -5 ], "bSortable": false, "bSearchable": false },
>                 { "aTargets": [ 0, 1 ], "sType": "natural" },
>             ],
>-            "bSort": false,
>+            "bSort": true,
>             "sPaginationType": "four_button"
>         }));
> 
>@@ -116,13 +116,13 @@
>         [% CASE 'error_on_update' %]
>             An error occurred when updating this framework. Perhaps it already exists.
>         [% CASE 'error_on_insert' %]
>-            An error occurred when inserting this framework. The framework might already exist.
>+            An error occurred when adding this framework. The framework might already exist.
>         [% CASE 'error_on_delete' %]
>             An error occurred when deleting this framework. Check the logs.
>         [% CASE 'success_on_update' %]
>             Framework updated successfully.
>         [% CASE 'success_on_insert' %]
>-            Framework inserted successfully.
>+            Framework added successfully.
>         [% CASE 'success_on_delete' %]
>             Framework deleted successfully.
>         [% CASE 'already_exists' %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14889: 42846 | 42847 | 43775 | 43776 | 43944 | 43974 | 43975 | 44493 | 44494 | 44495 | 44496 | 44497 | 44985 | 44986 | 44987 | 44988 | 44989 | 47857