Bugzilla – Attachment 44200 Details for
Bug 12540
Batch modifications for records - unavailable "Every" option
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12540: Display "Every" on editing a MMT action if previously selected
SIGNED-OFF-Bug-12540-Display-Every-on-editing-a-MM.patch (text/plain), 2.38 KB, created by
Alex Arnaud
on 2015-10-30 13:56:58 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12540: Display "Every" on editing a MMT action if previously selected
Filename:
MIME Type:
Creator:
Alex Arnaud
Created:
2015-10-30 13:56:58 UTC
Size:
2.38 KB
patch
obsolete
>From 006db72c6ef9d01fe736be20b7c275e984035419 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 22 Sep 2015 11:16:28 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 12540: Display "Every" on editing a MMT > action if previously selected > >On creating a marc modification template action, the "All" is changed with >"Every" if the condition field is the same as the original field. > >But on editing, the "All" value is not replaced. For consistency, it >should. > >Test plan: >1/ Create the following action: > Copy field 650$x to 650$y if 650$z matches "foobar" >Note that the "All" is replaced with "Every" when the condition is the >same field as the original field. >2/ Save >3/ Edit the action. >The "Every" should be selected. > >Without this patch, "All" is selected. > >Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> >--- > .../prog/en/modules/tools/marc_modification_templates.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >index 5cbc88d..0dcaab9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >@@ -442,7 +442,7 @@ function setSelectByValue( selectId, value ) { > "[% ActionsLoo.conditional_value |replace('\\\\', '\\\\') |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]", > "[% ActionsLoo.conditional_regex |replace('\\\\', '\\\\') |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]", > "[% ActionsLoo.description |replace('\\\\', '\\\\') |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]" >- )'>Edit</a></td> >+ );updateAllEvery();'>Edit</a></td> > <td><a href="marc_modification_templates.pl?template_id=[% ActionsLoo.template_id %]&op=delete_action&mmta_id=[% ActionsLoo.mmta_id %]">Delete</a></td> > </tr> > [% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12540
:
42767
|
44200
|
44580