From dfe6181220e3ba49c4cfbdc4d85b1dbc1c30e4d8 Mon Sep 17 00:00:00 2001 From: Kyle M Hall <kyle@bywatersolutions.com> Date: Thu, 17 Sep 2015 11:04:09 -0400 Subject: [PATCH] Bug 11431 [QA Followup] - Hard code list of sounds for security The sounds directory is no longer available for listing for security. It is better and safer to hard code the list of sounds. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> --- .../prog/en/modules/admin/audio_alerts.tt | 31 +++++++++++-------- 1 files changed, 18 insertions(+), 13 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt index d3471ce..82b3b87 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt @@ -4,19 +4,6 @@ <script type="text/javascript"> $( document ).ready(function() { - $.ajax({ - //This will retrieve the contents of the folder if the folder is configured as 'browsable' - url: AUDIO_ALERT_PATH, - success: function (data) { - $("#fileNames").html('<ul>'); - //List all png or jpg or gif file names in the page - $(data).find('a:contains("ogg")').each(function () { - var filename = this.href.split('/').pop(); - $('#koha-sounds').append($('<option>', { value : filename }).text(filename)); - }); - } - }); - $('#koha-sounds').on('change', function() { $('#sound').val( this.value ); }); @@ -72,6 +59,24 @@ $( document ).ready(function() { <select id="koha-sounds"> <option value="">Select built-in sound</option> + <option value="beep.ogg">beep.ogg</option> + <option value="call.ogg">call.ogg</option> + <option value="critical.ogg">critical.ogg</option> + <option value="device_connect.ogg">device_connect.ogg</option> + <option value="device_disconnect.ogg">device_disconnect.ogg</option> + <option value="ending.ogg">ending.ogg</option> + <option value="fail.ogg">fail.ogg</option> + <option value="IM_notification.ogg">IM_notification.ogg</option> + <option value="incoming_call.ogg">incoming_call.ogg</option> + <option value="loading.ogg">loading.ogg</option> + <option value="loading_2.ogg">loading_2.ogg</option> + <option value="maximize.ogg">maximize.ogg</option> + <option value="minimize.ogg">minimize.ogg</option> + <option value="new_mail_notification.ogg">new_mail_notification.ogg</option> + <option value="opening.ogg">opening.ogg</option> + <option value="panic.ogg">panic.ogg</option> + <option value="popup.ogg">popup.ogg</option> + <option value="warning.ogg">warning.ogg</option> </select> <button id="save-alert" type="submit" class="btn"><i class="icon-hdd"></i> Save alert</button> -- 1.7.2.5