Bugzilla – Attachment 44484 Details for
Bug 14544
Move the list related code to Koha::Virtualshelves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14544: [QA Follow-up] DBIx::Class changes
Bug-14544-QA-Follow-up-DBIxClass-changes.patch (text/plain), 1.80 KB, created by
Jonathan Druart
on 2015-11-05 11:08:54 UTC
(
hide
)
Description:
Bug 14544: [QA Follow-up] DBIx::Class changes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-11-05 11:08:54 UTC
Size:
1.80 KB
patch
obsolete
>From f9d9892638fe63444106f3a194ad9a259f0240a1 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 16 Oct 2015 09:09:17 +0200 >Subject: [PATCH] Bug 14544: [QA Follow-up] DBIx::Class changes > >One of the follow-ups added a belongs_to from Biblioitem to Item just >as biblioitemnumber was a foreign key to Item. The relation goes the >other way. > >As a temporary measure, I added set_primary_key in the local section of >Virtualshelfcontent. Should be moved later with a real db rev. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Schema/Result/Biblioitem.pm | 1 - > Koha/Schema/Result/Virtualshelfcontent.pm | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Schema/Result/Biblioitem.pm b/Koha/Schema/Result/Biblioitem.pm >index d34b2ef..a9b926a 100644 >--- a/Koha/Schema/Result/Biblioitem.pm >+++ b/Koha/Schema/Result/Biblioitem.pm >@@ -345,6 +345,5 @@ __PACKAGE__->has_many( > # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:A/4lKYlKWWd8TcMVzMRtCg > > __PACKAGE__->belongs_to( biblio => "Koha::Schema::Result::Biblio", "biblionumber" ); >-__PACKAGE__->belongs_to( items => "Koha::Schema::Result::Item", "biblioitemnumber" ); > > 1; >diff --git a/Koha/Schema/Result/Virtualshelfcontent.pm b/Koha/Schema/Result/Virtualshelfcontent.pm >index 906a058..a8ad19d 100644 >--- a/Koha/Schema/Result/Virtualshelfcontent.pm >+++ b/Koha/Schema/Result/Virtualshelfcontent.pm >@@ -141,6 +141,8 @@ __PACKAGE__->belongs_to( > # Created by DBIx::Class::Schema::Loader v0.07039 @ 2014-07-11 09:26:55 > # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:ie3Gx+/HthZQ/4fHjcPF0w > >+#TODO See BZ 14544: Should be resolved by db revision >+__PACKAGE__->set_primary_key("shelfnumber","biblionumber"); > > # You can replace this text with custom content, and it will be preserved on regeneration > 1; >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14544
:
41034
|
41035
|
41036
|
41037
|
41038
|
41039
|
41040
|
41041
|
41042
|
41403
|
41404
|
41405
|
41406
|
41407
|
41408
|
41409
|
41410
|
41411
|
41412
|
41584
|
41585
|
41586
|
41587
|
41588
|
41589
|
41590
|
41591
|
41592
|
41593
|
41594
|
41595
|
41596
|
41597
|
41598
|
41599
|
41600
|
41601
|
41716
|
41717
|
41718
|
41719
|
41720
|
41721
|
41722
|
41723
|
41724
|
41725
|
41726
|
41727
|
41728
|
41729
|
41730
|
41731
|
41732
|
41733
|
41766
|
41909
|
41910
|
41913
|
41914
|
41915
|
41917
|
41918
|
41919
|
41924
|
41927
|
41931
|
41932
|
41953
|
41954
|
41955
|
41956
|
41957
|
41958
|
41959
|
41960
|
41961
|
41962
|
41963
|
41964
|
41965
|
41966
|
41967
|
41968
|
41969
|
41970
|
41973
|
41974
|
41975
|
41976
|
41977
|
41978
|
41979
|
41980
|
41981
|
41982
|
41983
|
41986
|
41988
|
42192
|
42199
|
42200
|
42201
|
42202
|
42203
|
42204
|
42205
|
42206
|
42207
|
42208
|
42209
|
42210
|
42211
|
42212
|
42213
|
42214
|
42215
|
42216
|
42217
|
42218
|
42219
|
42638
|
43223
|
43224
|
43225
|
43226
|
43227
|
43228
|
43229
|
43230
|
43231
|
43232
|
43233
|
43234
|
43235
|
43236
|
43237
|
43238
|
43239
|
43240
|
43241
|
43242
|
43243
|
43296
|
43334
|
43335
|
43403
|
43456
|
43457
|
43458
|
43459
|
43460
|
43461
|
43462
|
43463
|
43464
|
43465
|
43466
|
43467
|
43469
|
43470
|
43471
|
43472
|
43473
|
43474
|
43475
|
43476
|
43477
|
43478
|
43479
|
43480
|
43481
|
43482
|
43485
|
43486
|
43487
|
44467
|
44468
|
44469
|
44470
|
44471
|
44472
|
44473
|
44474
|
44475
|
44476
|
44477
|
44478
|
44479
|
44480
|
44481
|
44482
|
44483
| 44484 |
44485
|
44486
|
44487
|
44758
|
44845
|
44852
|
44863
|
44872