Bugzilla – Attachment 44851 Details for
Bug 15189
The batch records modification tool should not close STDERR when running in background mode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15189: Do not close STDERR when running in background mode
Bug-15189-Do-not-close-STDERR-when-running-in-back.patch (text/plain), 1018 bytes, created by
Jonathan Druart
on 2015-11-13 16:37:51 UTC
(
hide
)
Description:
Bug 15189: Do not close STDERR when running in background mode
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-11-13 16:37:51 UTC
Size:
1018 bytes
patch
obsolete
>From 3cbe7c88ca8ece809de13349746d6250b0243d48 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 13 Nov 2015 16:22:03 +0000 >Subject: [PATCH] Bug 15189: Do not close STDERR when running in background > mode > >The batch records modification tool close STDERR, it's useless and hide >warnings/errors. > >Like the other processes using the BackgroundJob module, this one should >let it open. >--- > tools/batch_record_modification.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/tools/batch_record_modification.pl b/tools/batch_record_modification.pl >index 60775a9..5b46823 100755 >--- a/tools/batch_record_modification.pl >+++ b/tools/batch_record_modification.pl >@@ -167,7 +167,6 @@ if ( $op eq 'form' ) { > exit 0; > } elsif (defined $pid) { > close STDOUT; >- close STDERR; > } else { > warn "fork failed while attempting to run tools/batch_record_modification.pl as a background job"; > exit 0; >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15189
:
44851
|
44858
|
44891