From f4d978148e33d0bb2bcbdca2a4281f1a084c30cd Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 17 Nov 2015 10:20:39 -0300 Subject: [PATCH] [SIGNED-OFF]Bug 15199: t/db_dependent/Review.t should not depend on existing data This patch makes the tests create a branch and a patron category instead of searching for them on the DB. To test: - Apply the patch on current master - Run $ prove t/db_dependent/Review.t => SUCCESS: Tests pass - Sign off Signed-off-by: Hector Castro All test pass successful --- t/db_dependent/Review.t | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/t/db_dependent/Review.t b/t/db_dependent/Review.t index 6ef7867..381f5e8 100644 --- a/t/db_dependent/Review.t +++ b/t/db_dependent/Review.t @@ -17,7 +17,11 @@ # with Koha; if not, see . use Modern::Perl; + use Test::More tests => 117; +use t::lib::TestBuilder; + +use Koha::Database; use Time::Piece; BEGIN { @@ -41,16 +45,19 @@ can_ok( deletereview ) ); -my $dbh = C4::Context->dbh; -$dbh->{AutoCommit} = 0; -$dbh->{RaiseError} = 1; +my $schema = Koha::Database->new->schema; +$schema->storage->txn_begin; +our $dbh = C4::Context->dbh; + $dbh->do('DELETE FROM reviews'); $dbh->do('DELETE FROM issues'); $dbh->do('DELETE FROM borrowers'); +my $builder = t::lib::TestBuilder->new; + # ---------- Some borrowers for testing ------------------- -my $categorycode = Koha::Database->new()->schema()->resultset('Category')->first()->categorycode(); -my $branchcode = Koha::Database->new()->schema()->resultset('Branch')->first()->branchcode(); +my $categorycode = $builder->build({ source => 'Category' })->{ categorycode }; +my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode }; my $b1 = Koha::Borrower->new( { surname => 'Borrower 1', @@ -383,4 +390,6 @@ ok( !defined($review3), 'Review3 is no longer defined' ); $numberOfReviews = numberofreviews($status0) + numberofreviews($status1); is( $numberOfReviews, 0, 'There is no review left in database' ); -$dbh->rollback; +$schema->storage->txn_rollback; + +1; -- 1.7.10.4