Bugzilla – Attachment 4498 Details for
Bug 6501
Missing scroll bar when updating child
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-6501-missing-scroll-bar-when-updating-ch.patch (text/plain), 4.03 KB, created by
Owen Leonard
on 2011-06-16 13:04:39 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-06-16 13:04:39 UTC
Size:
4.03 KB
patch
obsolete
>From c8639b9199f61153e19084b184f8fd7a09587c2f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 16 Jun 2011 08:48:47 -0400 >Subject: [PATCH] Fix for Bug 6501 - missing scroll bar when updating child >Content-Type: text/plain; charset="utf-8" > >- Adding "scrollbars=yes" to window.open javascript. >- Adding javascript tablesorter to categories table > >To test, open a child patron record and choose more -> >Update Child to Adult Patron from the toolbar menu. The >resulting pop-up should have scrollbars. The table >of categories should be sortable with a default sort >on the description. >--- > .../prog/en/includes/circ-toolbar.inc | 2 +- > .../prog/en/includes/members-toolbar.inc | 2 +- > .../prog/en/modules/members/update-child.tt | 18 ++++++++++++++++-- > 3 files changed, 18 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-toolbar.inc >index 1377aa5..503f954 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-toolbar.inc >@@ -27,7 +27,7 @@ function confirm_reregistration() { > function update_child() { > // var borrowernumbervalue= $("#borrowernumber").attr("value"); > [% IF ( CATCODE_MULTI ) %] >- window.open('/cgi-bin/koha/members/update-child.pl?op=multi&borrowernumber=[% borrowernumber %]','UpdateChild','width=400,height=300,toolbar=no,scrollbars=no,resizable=yes'); >+ window.open('/cgi-bin/koha/members/update-child.pl?op=multi&borrowernumber=[% borrowernumber %]','UpdateChild','width=400,height=300,toolbar=no,scrollbars=yes,resizable=yes'); > [% ELSE %] > confirm_updatechild(); > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >index 9331f5f..afad863 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >@@ -25,7 +25,7 @@ function confirm_reregistration() { > > function update_child() { > [% IF ( CATCODE_MULTI ) %] >- window.open('update-child.pl?op=multi&borrowernumber=[% borrowernumber %]','UpdateChild','width=400,height=300,toolbar=no,scrollbars=no,resizable=yes'); >+ window.open('update-child.pl?op=multi&borrowernumber=[% borrowernumber %]','UpdateChild','width=400,height=300,toolbar=no,scrollbars=yes,resizable=yes'); > [% ELSE %] > confirm_updatechild(); > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/update-child.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/update-child.tt >index f73ce2d..81fa3b6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/update-child.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/update-child.tt >@@ -1,6 +1,16 @@ > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Choose Adult category</title> > [% INCLUDE 'doc-head-close.inc' %] >+<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.tablesorter.min.js"></script> >+<script type="text/javascript"> >+ $(document).ready(function() { >+ $.tablesorter.defaults.widgets = ['zebra']; >+ $("#catst").tablesorter({ >+ sortList: [[2,0]], >+ headers: { 0: { sorter: false }} >+ }); >+ }); >+</script> > <style type="text/css"> > #custom-doc { width:29em;*width:28.3em;min-width:377px; margin:auto; text-align:left; } > </style> >@@ -41,12 +51,15 @@ window.close(); > > <form method="post" action="update-child.pl"> > <fieldset> >-<table> >+<table id="catst"> >+<thead> > <tr> > <th> </th> > <th>Code</th> > <th>Description</th> > </tr> >+</thead> >+<tbody> > [% FOREACH CAT_LOO IN CAT_LOOP %] > <tr> > <td> >@@ -55,6 +68,7 @@ window.close(); > <td><label for="catcode[% CAT_LOO.catcode %]"><strong>[% CAT_LOO.catdesc %]</strong></label></td> > </tr> > [% END %] >+</tbody> > </table> > <input type="hidden" name="op" value="update" /> > <input type="hidden" name="borrowernumber" value="[% borrowernumber %]" /> >@@ -72,4 +86,4 @@ window.close(); > > > </div> >-[% INCLUDE 'intranet-bottom.inc' %] >+[% INCLUDE 'popup-bottom.inc' %] >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6501
:
4498
|
4500