Bugzilla – Attachment 45037 Details for
Bug 15215
Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 15215: Remove warning due to misuse of UNIVERSAL
SIGNED-OFF-Bug-15215-Remove-warning-due-to-misuse-.patch (text/plain), 1.54 KB, created by
Bernardo Gonzalez Kriegel
on 2015-11-20 11:50:04 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 15215: Remove warning due to misuse of UNIVERSAL
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2015-11-20 11:50:04 UTC
Size:
1.54 KB
patch
obsolete
>From 320b084eea6cf515b57e1d4634198d34c8bbe8c9 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 19 Nov 2015 12:15:34 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 15215: Remove warning due to misuse of > UNIVERSAL > >Calling UNIVERSAL's internal methods will cause a depreciation >warning in perls less that 5.22 as of 5.22 the warning is a fatal >error causing compilation to abort > >Replace the use UNIVERSAL with UNIVERSAL::can to work around the >buggy construct perldoc UNIVERSAL::can for more info > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >No more worning/error >No qa errors >--- > C4/Installer/PerlDependencies.pm | 5 +++++ > C4/SIP/Sip/MsgType.pm | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > >diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm >index e815cda..c1d03c7 100644 >--- a/C4/Installer/PerlDependencies.pm >+++ b/C4/Installer/PerlDependencies.pm >@@ -777,6 +777,11 @@ our $PERL_DEPS = { > 'required' => '0', > 'min_ver' => '0.28', > }, >+ 'UNIVERSAL::can' => { >+ 'usage' => 'SIP', >+ 'required' => '1', >+ 'min_ver' => '1.10', >+ }, > }; > > 1; >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index 3c74377..1e06a19 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -19,7 +19,7 @@ use Data::Dumper; > use CGI qw ( -utf8 ); > use C4::Auth qw(&check_api_auth); > >-use UNIVERSAL qw(can); # make sure this is *after* C4 modules. >+use UNIVERSAL::can; > > use vars qw(@ISA $VERSION @EXPORT_OK); > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15215
:
44992
|
45037
|
45043