From b3badb0fdd446ea836809c05dafeb47be62d4e5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20V=C3=A9ron?= Date: Tue, 1 Dec 2015 20:22:27 +0100 Subject: [PATCH] Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is set to "[Give] priority for filling holds to patrons whose... To verify: - Set syspref as above and run test. Test 14 fails. - Set syspref to [Don't give] and run test agein, it passes OK. To test: - Apply patch - Run test again with syspref set / not set Expected result: In both cases test should pass (AMended to change bug title) --- t/db_dependent/Reserves.t | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t index 7301757..8a6ab1c 100755 --- a/t/db_dependent/Reserves.t +++ b/t/db_dependent/Reserves.t @@ -280,6 +280,10 @@ is( $messages->{ResFound}->{borrowernumber}, # Return the FPL item at FPL. The hold that should be triggered is # the one placed by the RPL patron, as that patron is first in line # and RPL imposes no restrictions on whose holds its items can fill. + +# Ensure that the preference 'LocalHoldsPriority' is not set (Bug 15244): +C4::Context->set_preference( 'LocalHoldsPriority', '' ); + (undef, $messages, undef, undef) = AddReturn('bug10272_FPL', 'FPL'); is( $messages->{ResFound}->{borrowernumber}, $requesters{'RPL'}, -- 1.7.10.4