From 6406f15c45161764115911190da0ce3b3f73c17b Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Wed, 2 Dec 2015 18:19:30 -0500 Subject: [PATCH] Bug 14259: OPAC system preference BiblioDefaultView is ignored Cover image links ignore the BiblioDefaultView value for non-XSLT. TEST PLAN --------- 1) Back up your database 2) drop you db and do a fresh install of the sample data 3) set koha admin to a super librarian, and set up a username and password for it. 4) catalog "The Road To Character" by David Brooks. 5) using koha admin import a small set of data. 6) stop zebra and do a full reindex then restart it. 7) Change the 'OPACXSLTDetailsDisplay' and 'OPACXSLTResultsDisplay' system preferences to blank! -- This corrects the non-XSLT things missed by 12574. 7) Change the 'GoogleJackets' system preference to 'Add'. 8) Change the 'BiblioDefaultView' system preference to 'in their MARC form'. 9) Change the 'IDreamBooksResults' system preference to 'Add'. 10) Search for something that will find "The Road To Character" and something else in the OPAC. 11) Run your mouse over the title text in the search results. -- Link will be to opac-MARCdetail.pl 12) Run your mouse over the cover image or lack thereof. -- Link will be to opac-detail.pl -- This will fail for both "The Road to Character" and the non-"The Road to Character" entries. 13) Apply this patch 14) Refresh the OPAC page -- Links under the cover images will be corrected. 15) In the staff client, change 'IDreamBooksReviews' to 'Add'. 16) Refresh the OPAC page -- "The Road to Character" will be correct, but have a '#idb_critic_reviews' appended. 17) run koha qa test tools --- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt index e52291e..e22c2c2 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt @@ -22,6 +22,14 @@ [% INCLUDE 'masthead.inc' %] +[% IF BiblioDefaultViewmarc %] + [% SET OPACPage="opac-MARCdetail.pl" %] +[% ELSIF BiblioDefaultViewisbd %] + [% SET OPACPage="opac-ISBDdetail.pl" %] +[% ELSE %] + [% SET OPACPage="opac-detail.pl" %] +[% END %] +