From c87263e52c0d9fb5ad621a087d9646b3214a36ef Mon Sep 17 00:00:00 2001 From: Eivin Giske Skaaren Date: Wed, 28 Oct 2015 00:28:28 +0000 Subject: [PATCH] [PASSED QA] Bug 10154 Add Call number in the filter of most circulated items MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch adds call number, collection code and shelving location to the filter. To test: It is of course a prerequisite to have items in the DB with the correct MARC fields and that they have been checked out etc. to get a valid result when testing. 1. Apply patch to koha synced to master. 2. Go to /cgi-bin/koha/reports/cat_issues_top.pl 3. Select filters, the new ones are Call number, Collection code and Shelving location 4. Hit submit. Expected result: The filters chosen will be printed under "Filtered on". A table with the result is shown. For manual verification here is some SQL to run: SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues` LEFT JOIN items USING(itemnumber) LEFT JOIN biblio USING(biblionumber) LEFT JOIN biblioitems USING(biblionumber) LEFT JOIN borrowers USING(borrowernumber) WHERE 1 AND biblioitems.itemtype like 'BK' AND itemcallnumber like '005.2/762' AND ccode like 'NFIC' AND location like 'CART' AND borrowers.categorycode like 'PT' group by biblio.biblionumber order by RANK DESC; Put in your valid values in the WHERE clause for the values in the single quotes ''. Sponsored-by: Halland county library Signed-off-by: Frédéric Demians It works as described. Valid results, tested in various combinations. Follows the coding (awful) style of the original script, without introducing any regression. It would have been great to have callnumber interval, but anyway... Signed-off-by: Katrin Fischer --- .../prog/en/modules/reports/cat_issues_top.tt | 17 +++++ reports/cat_issues_top.pl | 72 +++++++++++++++++----- 2 files changed, 74 insertions(+), 15 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt index c76fba7..4cb69de 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt @@ -125,6 +125,23 @@
  • + +
  • +
  • + +
  • +
  • + +
  • +