From d1a0049317e76166eb017e67f08df7a6634b59b8 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Thu, 23 Apr 2015 14:15:07 -0400
Subject: [PATCH] Bug 13871 [QA Followup] - Rename parameter to
 send_msg_on_invalid_credentials

There are likely other services that would use this same feature.
Let's name it something a bit more general.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 C4/SIP/Sip/MsgType.pm |    6 +++---
 etc/SIPconfig.xml     |    3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
index 275e68c..91e0396 100644
--- a/C4/SIP/Sip/MsgType.pm
+++ b/C4/SIP/Sip/MsgType.pm
@@ -432,7 +432,7 @@ sub handle {
 #
 sub build_patron_status {
     my ( $patron, $lang, $fields, $server ) = @_;
-    my $overdrive_mode = $server->{account}->{'overdrive-mode'};
+    my $send_msg_on_invalid_credentials = $server->{account}->{'send_msg_on_invalid_credentials'};
     my $patron_pwd = $fields->{ (FID_PATRON_PWD) };
     my $resp = (PATRON_STATUS_RESP);
     my $password_ok = 1;
@@ -443,7 +443,7 @@ sub build_patron_status {
             $password_rc = $patron->check_password($patron_pwd);
             $password_ok = 0 unless $password_rc;
         }
-        elsif ( $overdrive_mode
+        elsif ( $send_msg_on_invalid_credentials
             and not exists $fields->{'AL'} # not block_request
             and not $patron_pwd ) # no password supplied
         {
@@ -477,7 +477,7 @@ sub build_patron_status {
     }
     else {
 
-        # Invalid patron id (and/or passwd for overdrive_mode)
+        # Invalid patron id (and/or passwd for send_msg_on_invalid_credentials)
         # Report that the user has no privs.
 
         # no personal name, and is invalid (if we're using 2.00)
diff --git a/etc/SIPconfig.xml b/etc/SIPconfig.xml
index 141bc4f..96da953 100644
--- a/etc/SIPconfig.xml
+++ b/etc/SIPconfig.xml
@@ -42,7 +42,8 @@
       <login id="lpl-sc" password="1234" institution="LPL" />
       <login id="lpl-sc-beacock" password="xyzzy"
              delimiter="|" error-detect="enabled" institution="LPL"
-             send_patron_home_library_in_af="1" >
+             send_patron_home_library_in_af="1"
+             send_msg_on_invalid_credentials="1">
           <screen_msg_regex find="Greetings from Koha." replace="Welcome to your library!" />
           <screen_msg_regex find="Invalid patron barcode." replace="Barcode not found, are you sure this is your library card?" />
       </login>
-- 
1.7.10.4